-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitOps mode in the UI #25478
Comments
Hey @rachaelshaw, I took a look at your early wireframes and recorded some feedback in a video here. |
Couple quick thoughts, one on where this could be turned on/off to minimize chances of someone bumping it by accident, one on temporary removal of GitOps mode. Maybe it makes sense to have this toggle not in the UI, instead being a setting in YAML next to the other global config settings. That way, to push the system into GitOps mode you have to know how to run GitOps, so that's less chance of folks locking themselves out. Plus add a way to turn GitOps Mode off via For an override, maybe we throw a git icon top-right next to the user profile icon when a global admin is in the UI and gitOps mode is turned on. Clicking the icon shows a quick explanation for GitOps Mode, plus a button (potentially leading to a confirmation modal) to temporarily disable GitOps Mode for the rest of that user's session. We can throw a flag in |
@sharon-fdm just a reminder that we want to prioritize this user story in the upcoming sprint. Can you please complete the TO-DOs in the "Engineering" section so we can estimate with the team during #g-orchestration sprint kickoff? |
@noahtalerman, Yes. We will put this on the front burner today and take it into the new sprint. |
Please add your planning poker estimate with Zenhub @jacobshandling |
@rachaelshaw thanks for the diligent spec work here! Since we are developing and updating specs in-flight, and since the designs are so wide-reaching, please ping me whenever you make updates to the Figma so I can be sure to note and get to implementing every added spec / change. So far I see specs added since estimation for Disk encryption, New query, and Edit query sections, and want to be sure I don't miss anything. |
@rachaelshaw seems like we'll want to gate the Add and Edit users tables as well, since users can be added/removed from teams there: ![]() Please confirm and note in this issue, thanks! cc @sgress454 |
Makes sense to me! |
Confirming the test plan in the description 👍 |
GitOps mode ascends, |
@jacobshandling @sharon-fdm This story shipped without a guide. It was listed in the engineering TODOs but looks like it never translated to a sub-task. I think this is probably a update of our existing GitOps guide to call out that GitOps Mode exists in the UI. @allenhouchins is a good resource on how we should document this. |
Thanks for the heads up @lukeheath |
What goes in the guide?
|
@jacobshandling here's our stubbed out article: #27368 |
Guide is merged! Thanks @jacobshandling :) |
GitOps mode takes flight, |
Goal
fleetctl gitops
runs.Key result
GitOps mode in the Fleet UI
Original requests
Context
Changes
Product
PRPRfleet-gitops
READMEEngineering
QA
Risk assessment
Test plan
"a.b.cc"
, it will navigate to<current_domain>/a.b.cc
. If a full path is provided, e.g."https://a.b.cc"
, it will navigate accordingly.Testing notes
Confirmation
The text was updated successfully, but these errors were encountered: