Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tidy3d.plugins.mode.web::run_batch with the native web.Batch #231

Open
momchil-flex opened this issue Jan 23, 2025 · 5 comments
Open
Assignees
Labels

Comments

@momchil-flex
Copy link
Collaborator

Many notebooks have been converted to use the run_batch function that was specifically implemented for the mode solver. However, this turns out to be unstable in some cases as it can e.g. open too many connections and time out. Now that the native web.Batch is enabled for the mode solver in 2.8, we should convert the examples to use that (and make sure all works fine).

@tomflexcompute who should take this?

@tomflexcompute
Copy link
Contributor

Yeah good to switch. I'll modify the notebooks and push a PR. I think there are only a few notebooks using run_batch right? Are you aware of any?

@momchil-flex
Copy link
Collaborator Author

I noticed that quite a lot turned up in this search which is why I made this issue. I assume at some point someone incorporated it, maybe @prashkh .

https://docs.flexcompute.com/projects/tidy3d/en/latest/search.html?q=mode+run_batch

@tomflexcompute
Copy link
Contributor

Oh yeah it's more than I thought. I'll change it. Do we have a timeline for 2.8.0 release?

@momchil-flex
Copy link
Collaborator Author

Will be wrapping 2.8.0rc2 up soon but then we want to let it get well tested before official 2.8.0, so not soon. Maybe end of February.

@tomflexcompute
Copy link
Contributor

Sounds good most people will still be in 2.7 for a while and I can update it before the 2.8 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants