Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize process of adding etcd members to the cluster #188

Open
invidian opened this issue Sep 19, 2020 · 1 comment
Open

Optimize process of adding etcd members to the cluster #188

invidian opened this issue Sep 19, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@invidian
Copy link
Member

Following etcd documentation, if new member is being added to the cluster, we first do API call to etcd cluster to inform it about the new member, then we create new containers.

However, the time slot between those 2 operations will cause an outage, if we add more members than quorum currently consist of (e.g. if you run 1 member and you add 1 member of if you run 3 members and you add 5 members). As creating containers may take a bit of time, depending on node connection speed and disk speed, it would be better to configure and create member containers first, then add new members, then just start the containers.

This could be added as a PreStart hook for container creation or we could globally only get all containers to created state. This way the impact will be greatly limited.

@invidian
Copy link
Member Author

invidian commented Mar 4, 2021

Also adding a member as a learner and then promoting it in PostStart hook once it catched up would be good.

@invidian invidian added the enhancement New feature or request label May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant