Fix: add missing tests on string functions

Author: f-lapinski

src/core/etl/tests/Flow/ETL/Tests/Unit/Function/IndexOfTest.php

@@ -51,4 +51,27 @@ public function test_returns_method_returns_string_int() : void
 
         self::assertTrue($returnType->isEqual(type_int()));
     }
+
+    public function test_string_null_index_of_returns_false() : void
+    {
+        self::assertFalse(
+            ref('str')->indexOf('x')->eval(
+                row(
+                    str_entry('str', null),
+                )
+            )
+        );
+    }
+
+    public function test_needle_null_index_of_returns_false() : void
+    {
+        self::assertFalse(
+            ref('str')->indexOf(ref('needle'))->eval(
+                row(
+                    str_entry('str', 'x'),
+                    str_entry('needle', null)
+                )
+            )
+        );
+    }
 }

src/core/etl/tests/Flow/ETL/Tests/Unit/Function/IsUtf8Test.php

@@ -36,4 +36,15 @@ public function test_returns_method_returns_string_boolean() : void
 
         self::assertTrue($returnType->isEqual(type_boolean()));
     }
+
+    public function test_is_utf8_returns_null() : void
+    {
+        self::assertNull(
+            ref('str')->isUtf8()->eval(
+                row(
+                    str_entry('str', null),
+                )
+            )
+        );
+    }
 }

src/core/etl/tests/Flow/ETL/Tests/Unit/Function/StringAfterTest.php

@@ -4,6 +4,7 @@
 
 namespace Flow\ETL\Tests\Unit\Function;
 
+use Flow\ETL\Function\StringAfter;
 use function Flow\ETL\DSL\row;
 use function Flow\ETL\DSL\{ref, str_entry, type_string};
 use Flow\ETL\Function\StringTitle;
@@ -14,8 +15,8 @@ final class StringAfterTest extends FlowTestCase
 {
     public function test_returns_method_returns_string_type() : void
     {
-        $stringTitleFunction = new StringTitle('str');
-        $returnType = $stringTitleFunction->returns();
+        $stringAfterFunction = new StringAfter('test', 'e');
+        $returnType = $stringAfterFunction->returns();
 
         self::assertInstanceOf(Type::class, $returnType);
 
@@ -57,4 +58,15 @@ public function test_string_after_including_needle() : void
             )
         );
     }
+
+    public function test_string_after_returns_null() : void
+    {
+        self::assertFalse(
+            ref('str')->stringAfter('x')->eval(
+                row(
+                    str_entry('str', null),
+                )
+            )
+        );
+    }
 }

src/core/etl/tests/Flow/ETL/Tests/Unit/Function/StringFoldTest.php

@@ -4,12 +4,23 @@
 
 namespace Flow\ETL\Tests\Unit\Function;
 
+use Flow\ETL\Function\StringFold;
+use Flow\ETL\PHP\Type\Type;
 use function Flow\ETL\DSL\row;
-use function Flow\ETL\DSL\{ref, str_entry};
+use function Flow\ETL\DSL\{ref, str_entry, type_string};
 use Flow\ETL\Tests\FlowTestCase;
 
 final class StringFoldTest extends FlowTestCase
 {
+    public function test_returns_method_returns_string_type() : void
+    {
+        $stringFoldedFunction = new StringFold('str');
+        $returnType = $stringFoldedFunction->returns();
+
+        self::assertInstanceOf(Type::class, $returnType);
+
+        self::assertTrue($returnType->isEqual(type_string()));
+    }
     public function test_string_folded() : void
     {
         self::assertSame(
@@ -19,4 +30,15 @@ public function test_string_folded() : void
             )
         );
     }
+
+    public function test_string_folded_returns_null() : void
+    {
+        self::assertNull(
+            ref('str')->stringFold()->eval(
+                row(
+                    str_entry('str', null),
+                )
+            )
+        );
+    }
 }

src/core/etl/tests/Flow/ETL/Tests/Unit/Function/StringStyleTest.php

@@ -85,4 +85,15 @@ public function test_string_style_upper() : void
             )
         );
     }
+
+    public function test_string_style_returns_null() : void
+    {
+        self::assertNull(
+            ref('str')->stringStyle(StringStyles::LOWER)->eval(
+                row(
+                    str_entry('str', null),
+                )
+            )
+        );
+    }
 }

src/core/etl/tests/Flow/ETL/Tests/Unit/Function/StringTitleTest.php

@@ -41,4 +41,15 @@ public function test_string_title_allwords() : void
             )
         );
     }
+
+    public function test_string_title_returns_null() : void
+    {
+        self::assertNull(
+            ref('str')->stringTitle()->eval(
+                row(
+                    str_entry('str', null),
+                )
+            )
+        );
+    }
 }