Memorize if path is a pattern

flow-php · Apr 12, 2024 · 4ad09b3 · 4ad09b3
1 parent 662943c
commit 4ad09b3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/core/etl/src/Flow/ETL/Filesystem/Path.php b/src/core/etl/src/Flow/ETL/Filesystem/Path.php
@@ -16,6 +16,8 @@ final class Path
 
     private string $filename;
 
+    private ?bool $isPattern = null;
+
     private ?Partitions $partitions = null;
 
     private string $path;
@@ -206,7 +208,13 @@ public function isLocal() : bool
 
     public function isPattern() : bool
     {
-        return $this->isPathPattern($this->path);
+        if ($this->isPattern !== null) {
+            return $this->isPattern;
+        }
+
+        $this->isPattern = $this->isPathPattern($this->path);
+
+        return $this->isPattern;
     }
 
     public function matches(self $path) : bool

diff --git a/src/core/etl/src/Flow/ETL/Rows.php b/src/core/etl/src/Flow/ETL/Rows.php
@@ -62,7 +62,7 @@ public function add(Row ...$rows) : self
     }
 
     /**
-     * return array<Row>.
+     * @return array<Row>
      */
     public function all() : array
     {
-Original file line number
+Diff line change
@@ Expand Up / @@ -62,7 +62,7 @@ public function add(Row ...$rows) : self @@
         }
         /**
-         * return array<Row>.
+         * @return array<Row>
          */
         public function all() : array
         {
@@ Expand Down @@