Skip to content

Commit 90a0ff7

Browse files
committed
Removed Pipeline::closure
1 parent dd79352 commit 90a0ff7

File tree

9 files changed

+5
-47
lines changed

9 files changed

+5
-47
lines changed

src/core/etl/src/Flow/ETL/Pipeline.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ interface Pipeline
1313
{
1414
public function add(Loader|Transformer $pipe) : self;
1515

16-
public function closure(FlowContext $context) : void;
17-
1816
public function has(string $transformerClass) : bool;
1917

2018
public function pipes() : Pipes;

src/core/etl/src/Flow/ETL/Pipeline/BatchingPipeline.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,11 +30,6 @@ public function add(Loader|Transformer $pipe) : self
3030
return $this;
3131
}
3232

33-
public function closure(FlowContext $context) : void
34-
{
35-
$this->pipeline->closure($context);
36-
}
37-
3833
public function has(string $transformerClass) : bool
3934
{
4035
return $this->pipeline->has($transformerClass);

src/core/etl/src/Flow/ETL/Pipeline/CachingPipeline.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@ public function add(Loader|Transformer $pipe) : Pipeline
1919
return $this;
2020
}
2121

22-
public function closure(FlowContext $context) : void
23-
{
24-
$this->pipeline->closure($context);
25-
}
26-
2722
public function has(string $transformerClass) : bool
2823
{
2924
return $this->pipeline->has($transformerClass);

src/core/etl/src/Flow/ETL/Pipeline/CollectingPipeline.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@ public function add(Loader|Transformer $pipe) : self
2828
return $this;
2929
}
3030

31-
public function closure(FlowContext $context) : void
32-
{
33-
$this->pipeline->closure($context);
34-
}
35-
3631
public function has(string $transformerClass) : bool
3732
{
3833
return $this->pipeline->has($transformerClass);

src/core/etl/src/Flow/ETL/Pipeline/GroupByPipeline.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,6 @@ public function add(Loader|Transformer $pipe) : self
2222
return $this;
2323
}
2424

25-
public function closure(FlowContext $context) : void
26-
{
27-
$this->pipeline->closure($context);
28-
}
29-
3025
public function has(string $transformerClass) : bool
3126
{
3227
return $this->pipeline->has($transformerClass);

src/core/etl/src/Flow/ETL/Pipeline/LinkedPipeline.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,6 @@ public function add(Loader|Transformer $pipe) : Pipeline
2323
return $this;
2424
}
2525

26-
public function closure(FlowContext $context) : void
27-
{
28-
$this->pipeline->closure($context);
29-
}
30-
3126
public function has(string $transformerClass) : bool
3227
{
3328
return $this->pipeline->has($transformerClass);

src/core/etl/src/Flow/ETL/Pipeline/PartitioningPipeline.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ public function add(Loader|Transformer $pipe) : Pipeline
3636
return $this;
3737
}
3838

39-
public function closure(FlowContext $context) : void
40-
{
41-
$this->pipeline->closure($context);
42-
}
43-
4439
public function has(string $transformerClass) : bool
4540
{
4641
return $this->pipeline->has($transformerClass);

src/core/etl/src/Flow/ETL/Pipeline/SynchronousPipeline.php

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,6 @@ public function add(Loader|Transformer $pipe) : self
2929
return $this;
3030
}
3131

32-
public function closure(FlowContext $context) : void
33-
{
34-
foreach ($this->pipes->all() as $pipe) {
35-
if ($pipe instanceof Loader && $pipe instanceof Closure) {
36-
$pipe->closure($context);
37-
}
38-
}
39-
}
40-
4132
public function has(string $transformerClass) : bool
4233
{
4334
return $this->pipes->has($transformerClass);
@@ -84,7 +75,11 @@ public function process(FlowContext $context) : \Generator
8475
}
8576
}
8677

87-
$this->closure($context);
78+
foreach ($this->pipes->all() as $pipe) {
79+
if ($pipe instanceof Loader && $pipe instanceof Closure) {
80+
$pipe->closure($context);
81+
}
82+
}
8883
}
8984

9085
public function setSource(Extractor $extractor) : self

src/core/etl/src/Flow/ETL/Pipeline/VoidPipeline.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ public function add(Loader|Transformer $pipe) : self
1717
return $this;
1818
}
1919

20-
public function closure(FlowContext $context) : void
21-
{
22-
$this->pipeline->closure($context);
23-
}
24-
2520
public function has(string $transformerClass) : bool
2621
{
2722
return $this->pipeline->has($transformerClass);

0 commit comments

Comments
 (0)