Merge pull request #28 from flownative/task/sanitize-settings

kdambekalns · web-flow · commit f655f0f735dc · 2024-11-04T07:57:05.000Z
Sanitize settings properly
diff --git a/Classes/SentryClient.php b/Classes/SentryClient.php
@@ -83,9 +83,9 @@ class SentryClient
 
     public function injectSettings(array $settings): void
     {
-        $this->dsn = $settings['dsn'] ?? '';
-        $this->environment = $settings['environment'] ?? '';
-        $this->release = $settings['release'] ?? '';
+        $this->dsn = $settings['dsn'] ?: '';
+        $this->environment = $settings['environment'] ?: '';
+        $this->release = $settings['release'] ?: '';
         $this->sampleRate = (float)($settings['sampleRate'] ?? 1);
         $this->excludeExceptionTypes = $settings['capture']['excludeExceptionTypes'] ?? [];
     }

Original file line number	Diff line number	Diff line change
`@@ -83,9 +83,9 @@ class SentryClient`
`83`	`83`
`84`	`84`	`public function injectSettings(array $settings): void`
`85`	`85`	`{`
`86`		`- $this->dsn = $settings['dsn'] ?? '';`
`87`		`- $this->environment = $settings['environment'] ?? '';`
`88`		`- $this->release = $settings['release'] ?? '';`
	`86`	`+ $this->dsn = $settings['dsn'] ?: '';`
	`87`	`+ $this->environment = $settings['environment'] ?: '';`
	`88`	`+ $this->release = $settings['release'] ?: '';`
`89`	`89`	`$this->sampleRate = (float)($settings['sampleRate'] ?? 1);`
`90`	`90`	`$this->excludeExceptionTypes = $settings['capture']['excludeExceptionTypes'] ?? [];`
`91`	`91`	`}`