Skip to content

Commit 4b48c83

Browse files
committed
renaming
1 parent 9d9d685 commit 4b48c83

22 files changed

+65
-66
lines changed

src/FluentAssertions.Analyzers.Tests/Tips/CollectionTests.cs

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ public class CollectionTests
1515
[NotImplemented]
1616
public void NoDiagnostics(string assertion) => VerifyCSharpNoDiagnosticsCodeBlock(assertion);
1717

18-
1918
[AssertionDataTestMethod]
2019
[AssertionDiagnostic("actual.Any().Should().BeTrue({0});")]
2120
[AssertionDiagnostic("actual.AsEnumerable().Any().Should().BeTrue({0}).And.ToString();")]

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldBeInAscendingOrder.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ public class CollectionShouldBeInAscendingOrderCodeFix : FluentAssertionsCodeFix
4141
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4242
{
4343
var remove = NodeReplacement.RemoveAndExtractArguments("OrderBy");
44-
var newStatement = GetNewExpression(expression, remove);
44+
var newExpression = GetNewExpression(expression, remove);
4545

46-
newStatement = GetNewExpression(newStatement, NodeReplacement.RenameAndRemoveFirstArgument("Equal", "BeInAscendingOrder"));
46+
newExpression = GetNewExpression(newExpression, NodeReplacement.RenameAndRemoveFirstArgument("Equal", "BeInAscendingOrder"));
4747

48-
return GetNewExpression(newStatement, NodeReplacement.PrependArguments("BeInAscendingOrder", remove.Arguments));
48+
return GetNewExpression(newExpression, NodeReplacement.PrependArguments("BeInAscendingOrder", remove.Arguments));
4949
}
5050
}
5151
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldBeInDescendingOrder.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ public class CollectionShouldBeInDescendingOrderCodeFix : FluentAssertionsCodeFi
4141
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4242
{
4343
var remove = NodeReplacement.RemoveAndExtractArguments("OrderByDescending");
44-
var newStatement = GetNewExpression(expression, remove);
44+
var newExpression = GetNewExpression(expression, remove);
4545

46-
newStatement = GetNewExpression(newStatement, NodeReplacement.RenameAndRemoveFirstArgument("Equal", "BeInDescendingOrder"));
46+
newExpression = GetNewExpression(newExpression, NodeReplacement.RenameAndRemoveFirstArgument("Equal", "BeInDescendingOrder"));
4747

48-
return GetNewExpression(newStatement, NodeReplacement.PrependArguments("BeInDescendingOrder", remove.Arguments));
48+
return GetNewExpression(newExpression, NodeReplacement.PrependArguments("BeInDescendingOrder", remove.Arguments));
4949
}
5050
}
5151
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldContainItem.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ public class CollectionShouldContainItemCodeFix : FluentAssertionsCodeFixProvide
4242
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4343
{
4444
var remove = new NodeReplacement.RemoveAndExtractArgumentsNodeReplacement("Contains");
45-
var newStatement = GetNewExpression(expression, remove);
45+
var newExpression = GetNewExpression(expression, remove);
4646

47-
return GetNewExpression(newStatement, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("BeTrue", "Contain", remove.Arguments));
47+
return GetNewExpression(newExpression, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("BeTrue", "Contain", remove.Arguments));
4848
}
4949
}
5050
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldContainProperty.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -51,16 +51,16 @@ protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression
5151
if (properties.VisitorName == nameof(CollectionShouldContainPropertyAnalyzer.AnyShouldBeTrueSyntaxVisitor))
5252
{
5353
var remove = new NodeReplacement.RemoveAndExtractArgumentsNodeReplacement("Any");
54-
var newStatement = GetNewExpression(expression, remove);
54+
var newExpression = GetNewExpression(expression, remove);
5555

56-
return GetNewExpression(newStatement, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("BeTrue", "Contain", remove.Arguments));
56+
return GetNewExpression(newExpression, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("BeTrue", "Contain", remove.Arguments));
5757
}
5858
else if (properties.VisitorName == nameof(CollectionShouldContainPropertyAnalyzer.WhereShouldNotBeEmptySyntaxVisitor))
5959
{
6060
var remove = new NodeReplacement.RemoveAndExtractArgumentsNodeReplacement("Where");
61-
var newStatement = GetNewExpression(expression, remove);
61+
var newExpression = GetNewExpression(expression, remove);
6262

63-
return GetNewExpression(newStatement, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("NotBeEmpty", "Contain", remove.Arguments));
63+
return GetNewExpression(newExpression, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("NotBeEmpty", "Contain", remove.Arguments));
6464
}
6565
throw new System.InvalidOperationException($"Invalid visitor name - {properties.VisitorName}");
6666
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldContainSingle.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,17 @@ public class CollectionShouldContainSingleCodeFix : FluentAssertionsCodeFixProvi
4848

4949
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
5050
{
51-
var newStatement = GetNewExpression(expression, NodeReplacement.RenameAndRemoveFirstArgument("HaveCount", "ContainSingle"));
51+
var newExpression = GetNewExpression(expression, NodeReplacement.RenameAndRemoveFirstArgument("HaveCount", "ContainSingle"));
5252
if (properties.VisitorName == nameof(CollectionShouldContainSingleAnalyzer.ShouldHaveCount1SyntaxVisitor))
5353
{
54-
return newStatement;
54+
return newExpression;
5555
}
5656
else if (properties.VisitorName == nameof(CollectionShouldContainSingleAnalyzer.WhereShouldHaveCount1SyntaxVisitor))
5757
{
5858
var remove = NodeReplacement.RemoveAndExtractArguments("Where");
59-
newStatement = GetNewExpression(newStatement, remove);
59+
newExpression = GetNewExpression(newExpression, remove);
6060

61-
return GetNewExpression(newStatement, NodeReplacement.PrependArguments("ContainSingle", remove.Arguments));
61+
return GetNewExpression(newExpression, NodeReplacement.PrependArguments("ContainSingle", remove.Arguments));
6262
}
6363
throw new System.InvalidOperationException($"Invalid visitor name - {properties.VisitorName}");
6464
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldEqualOtherCollectionByComparer.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ public class CollectionShouldEqualOtherCollectionByComparerCodeFix : FluentAsser
5252
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
5353
{
5454
var removeMethodContainingFirstLambda = NodeReplacement.RemoveAndExtractArguments("Select");
55-
var newStatement = GetNewExpression(expression, removeMethodContainingFirstLambda);
55+
var newExpression = GetNewExpression(expression, removeMethodContainingFirstLambda);
5656

5757
var removeArgument = NodeReplacement.RemoveFirstArgument("Equal");
58-
newStatement = GetNewExpression(newStatement, removeArgument);
58+
newExpression = GetNewExpression(newExpression, removeArgument);
5959

6060
var argumentInvocation = (InvocationExpressionSyntax)removeArgument.Argument.Expression;
6161
var identifier = ((MemberAccessExpressionSyntax)argumentInvocation.Expression).Expression;
@@ -68,7 +68,7 @@ protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression
6868
.Add(removeArgument.Argument.WithExpression(CombineLambdas(firstLambda, secondLambda).NormalizeWhitespace()
6969
));
7070

71-
return GetNewExpression(newStatement, NodeReplacement.PrependArguments("Equal", newArguments));
71+
return GetNewExpression(newExpression, NodeReplacement.PrependArguments("Equal", newArguments));
7272
}
7373

7474
private ParenthesizedLambdaExpressionSyntax CombineLambdas(SimpleLambdaExpressionSyntax left, SimpleLambdaExpressionSyntax right) => SyntaxFactory.ParenthesizedLambdaExpression(

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldHaveElementAt.cs

+6-6
Original file line numberDiff line numberDiff line change
@@ -59,23 +59,23 @@ protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression
5959
if (properties.VisitorName == nameof(CollectionShouldHaveElementAtAnalyzer.ElementAtIndexShouldBeSyntaxVisitor))
6060
{
6161
var remove = NodeReplacement.RemoveAndExtractArguments("ElementAt");
62-
var newStatement = GetNewExpression(expression, remove);
62+
var newExpression = GetNewExpression(expression, remove);
6363

64-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("Be", "HaveElementAt", remove.Arguments));
64+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("Be", "HaveElementAt", remove.Arguments));
6565
}
6666
else if (properties.VisitorName == nameof(CollectionShouldHaveElementAtAnalyzer.IndexerShouldBeSyntaxVisitor))
6767
{
6868
var remove = NodeReplacement.RemoveAndRetrieveIndexerArguments("Should");
69-
var newStatement = GetNewExpression(expression, remove);
69+
var newExpression = GetNewExpression(expression, remove);
7070

71-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("Be", "HaveElementAt", remove.Arguments));
71+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("Be", "HaveElementAt", remove.Arguments));
7272
}
7373
else if (properties.VisitorName == nameof(CollectionShouldHaveElementAtAnalyzer.SkipFirstShouldBeSyntaxVisitor))
7474
{
7575
var remove = NodeReplacement.RemoveAndExtractArguments("Skip");
76-
var newStatement = GetNewExpression(expression, remove, NodeReplacement.Remove("First"));
76+
var newExpression = GetNewExpression(expression, remove, NodeReplacement.Remove("First"));
7777

78-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("Be", "HaveElementAt", remove.Arguments));
78+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("Be", "HaveElementAt", remove.Arguments));
7979
}
8080
throw new System.InvalidOperationException($"Invalid visitor name - {properties.VisitorName}");
8181
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldIntersectWith.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ public class CollectionShouldIntersectWithCodeFix : FluentAssertionsCodeFixProvi
4141
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4242
{
4343
var remove = NodeReplacement.RemoveAndExtractArguments("Intersect");
44-
var newStatement = GetNewExpression(expression, remove);
44+
var newExpression = GetNewExpression(expression, remove);
4545

46-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("NotBeEmpty", "IntersectWith", remove.Arguments));
46+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("NotBeEmpty", "IntersectWith", remove.Arguments));
4747
}
4848
}
4949
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldNotBeNullOrEmpty.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,16 @@ protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression
6363
if (properties.VisitorName == nameof(CollectionShouldNotBeNullOrEmptyAnalyzer.ShouldNotBeNullAndNotBeEmptySyntaxVisitor))
6464
{
6565
var remove = NodeReplacement.RemoveAndExtractArguments("NotBeEmpty");
66-
var newStatement = GetNewExpression(expression, remove);
66+
var newExpression = GetNewExpression(expression, remove);
6767

68-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("NotBeNull", "NotBeNullOrEmpty", remove.Arguments));
68+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("NotBeNull", "NotBeNullOrEmpty", remove.Arguments));
6969
}
7070
else if (properties.VisitorName == nameof(CollectionShouldNotBeNullOrEmptyAnalyzer.ShouldNotBeEmptyAndNotBeNullSyntaxVisitor))
7171
{
7272
var remove = NodeReplacement.RemoveAndExtractArguments("NotBeNull");
73-
var newStatement = GetNewExpression(expression, remove);
73+
var newExpression = GetNewExpression(expression, remove);
7474

75-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("NotBeEmpty", "NotBeNullOrEmpty", remove.Arguments));
75+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("NotBeEmpty", "NotBeNullOrEmpty", remove.Arguments));
7676
}
7777
throw new System.InvalidOperationException($"Invalid visitor name - {properties.VisitorName}");
7878
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldNotContainItem.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ public class CollectionShouldNotContainItemCodeFix : FluentAssertionsCodeFixProv
4141
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4242
{
4343
var remove = new NodeReplacement.RemoveAndExtractArgumentsNodeReplacement("Contains");
44-
var newStatement = GetNewExpression(expression, remove);
44+
var newExpression = GetNewExpression(expression, remove);
4545

46-
return GetNewExpression(newStatement, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("BeFalse", "NotContain", remove.Arguments));
46+
return GetNewExpression(newExpression, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("BeFalse", "NotContain", remove.Arguments));
4747
}
4848
}
4949
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldNotContainNulls.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ public class CollectionShouldNotContainNullsCodeFix : FluentAssertionsCodeFixPro
4141
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4242
{
4343
var remove = NodeReplacement.RemoveAndExtractArguments("Select");
44-
var newStatement = GetNewExpression(expression, remove);
44+
var newExpression = GetNewExpression(expression, remove);
4545

46-
return GetNewExpression(newStatement, NodeReplacement.PrependArguments("NotContainNulls", remove.Arguments));
46+
return GetNewExpression(newExpression, NodeReplacement.PrependArguments("NotContainNulls", remove.Arguments));
4747
}
4848
}
4949
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldNotContainProperty.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -59,16 +59,16 @@ protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression
5959
if (properties.VisitorName == nameof(CollectionShouldNotContainPropertyAnalyzer.AnyShouldBeFalseSyntaxVisitor))
6060
{
6161
var remove = new NodeReplacement.RemoveAndExtractArgumentsNodeReplacement("Any");
62-
var newStatement = GetNewExpression(expression, remove);
62+
var newExpression = GetNewExpression(expression, remove);
6363

64-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("BeFalse", "NotContain", remove.Arguments));
64+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("BeFalse", "NotContain", remove.Arguments));
6565
}
6666
else if (properties.VisitorName == nameof(CollectionShouldNotContainPropertyAnalyzer.WhereShouldBeEmptySyntaxVisitor))
6767
{
6868
var remove = new NodeReplacement.RemoveAndExtractArgumentsNodeReplacement("Where");
69-
var newStatement = GetNewExpression(expression, remove);
69+
var newExpression = GetNewExpression(expression, remove);
7070

71-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("BeEmpty", "NotContain", remove.Arguments));
71+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("BeEmpty", "NotContain", remove.Arguments));
7272
}
7373
else if (properties.VisitorName == nameof(CollectionShouldNotContainPropertyAnalyzer.ShouldOnlyContainNotSyntaxVisitor))
7474
{

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldNotIntersectWith.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -40,9 +40,9 @@ public class CollectionShouldNotIntersectWithCodeFix : FluentAssertionsCodeFixPr
4040
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4141
{
4242
var remove = NodeReplacement.RemoveAndExtractArguments("Intersect");
43-
var newStatement = GetNewExpression(expression, remove);
43+
var newExpression = GetNewExpression(expression, remove);
4444

45-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("BeEmpty", "NotIntersectWith", remove.Arguments));
45+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("BeEmpty", "NotIntersectWith", remove.Arguments));
4646
}
4747
}
4848
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldOnlyContainProperty.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ public class CollectionShouldOnlyContainPropertyCodeFix : FluentAssertionsCodeFi
4242
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4343
{
4444
var remove = new NodeReplacement.RemoveAndExtractArgumentsNodeReplacement("All");
45-
var newStatement = GetNewExpression(expression, remove);
45+
var newExpression = GetNewExpression(expression, remove);
4646

47-
return GetNewExpression(newStatement, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("BeTrue", "OnlyContain", remove.Arguments));
47+
return GetNewExpression(newExpression, new NodeReplacement.RenameAndPrependArgumentsNodeReplacement("BeTrue", "OnlyContain", remove.Arguments));
4848
}
4949
}
5050
}

src/FluentAssertions.Analyzers/Tips/Collections/CollectionShouldOnlyHaveUniqueItemsByComparer.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,9 @@ public class CollectionShouldOnlyHaveUniqueItemsByComparerCodeFix : FluentAssert
4242
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4343
{
4444
var remove = NodeReplacement.RemoveAndExtractArguments("Select");
45-
var newStatement = GetNewExpression(expression, remove);
45+
var newExpression = GetNewExpression(expression, remove);
4646

47-
return GetNewExpression(newStatement, NodeReplacement.PrependArguments("OnlyHaveUniqueItems", remove.Arguments));
47+
return GetNewExpression(newExpression, NodeReplacement.PrependArguments("OnlyHaveUniqueItems", remove.Arguments));
4848
}
4949
}
5050
}

src/FluentAssertions.Analyzers/Tips/Dictionaries/DictionaryShouldContainKey.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ public class DictionaryShouldContainKeyCodeFix : FluentAssertionsCodeFixProvider
4141
protected override ExpressionSyntax GetNewExpression(ExpressionSyntax expression, FluentAssertionsDiagnosticProperties properties)
4242
{
4343
var remove = NodeReplacement.RemoveAndExtractArguments("ContainsKey");
44-
var newStatement = GetNewExpression(expression, remove);
44+
var newExpression = GetNewExpression(expression, remove);
4545

46-
return GetNewExpression(newStatement, NodeReplacement.RenameAndPrependArguments("BeTrue", "ContainKey", remove.Arguments));
46+
return GetNewExpression(newExpression, NodeReplacement.RenameAndPrependArguments("BeTrue", "ContainKey", remove.Arguments));
4747
}
4848
}
4949
}

0 commit comments

Comments
 (0)