Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new Flutter version APIs, fix errors. #229

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

gspencergoog
Copy link
Contributor

Description

This fixes some errors that have crept in with some Flutter API changes, and upgrades all of the pubspec packages to newer versions.

It also fixes some some overflow layout issues, and updates the platform shims for all of the packages.

@gspencergoog gspencergoog force-pushed the fix_errors branch 2 times, most recently from 5ddb923 to 71701c9 Compare December 2, 2023 02:52
@gspencergoog gspencergoog removed the request for review from goderbauer December 2, 2023 02:58
@gspencergoog gspencergoog marked this pull request as draft December 2, 2023 03:34
@gspencergoog gspencergoog marked this pull request as ready for review December 2, 2023 03:34
@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2023
Copy link

auto-submit bot commented Dec 2, 2023

auto label is removed for flutter/assets-for-api-docs/229, Failed to merge flutter/assets-for-api-docs/229 with Pull request flutter/assets-for-api-docs/229 could not be merged: Required status check "WIP" is expected..

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2023
Copy link

auto-submit bot commented Dec 2, 2023

auto label is removed for flutter/assets-for-api-docs/229, Failed to merge flutter/assets-for-api-docs/229 with Pull request flutter/assets-for-api-docs/229 could not be merged: Required status check "WIP" is expected..

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2023
Copy link

auto-submit bot commented Dec 2, 2023

auto label is removed for flutter/assets-for-api-docs/229, Failed to merge flutter/assets-for-api-docs/229 with Pull request flutter/assets-for-api-docs/229 could not be merged: Required status check "WIP" is expected..

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 2, 2023
@gspencergoog gspencergoog mentioned this pull request Dec 2, 2023
@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 4, 2023
@auto-submit auto-submit bot merged commit 39fd2b0 into flutter:main Dec 4, 2023
auto-submit bot pushed a commit that referenced this pull request Dec 4, 2023
Updates the assets after fixing code in #229

I've done a check of all of the PNGs, and spot checked the videos.
@paldepind
Copy link
Contributor

Perhaps I'm doing something wrong, but I can't figure out how to generate the diagrams after this change.

From this PR process v5.0.1 is required but the latest Flutter release 3.16.4 pins that package to 4.2.4 (double-checked by downloading the latest release zip and checking the content of packages/flutter/pubspec.yaml).

I also tried running the script with the latest Flutter from master bug I get a bunch of compilation errors.

@gspencergoog
Copy link
Contributor Author

Huh. I'll check into it.

@gspencergoog gspencergoog deleted the fix_errors branch December 20, 2023 17:58
@gspencergoog
Copy link
Contributor Author

@paldepind Well, I'm able to build and run generate against the latest Flutter main channel.

I'd try cleaning up your git repo with something like git clean -dxf (warning: will delete all non-git controlled files in the local repo) and build again. If that doesn't help, you might also delete your ~/.pub-cache directory in case there is something corrupt in there.

My flutter doctor -v
[✓] Flutter (Channel main, 3.18.0-14.0.pre.34, on macOS 14.2 23C64 darwin-arm64, locale en)
    • Flutter version 3.18.0-14.0.pre.34 on channel main at /Users/gspencer/code/flutter
    • Upstream repository [email protected]:flutter/flutter.git
    • Framework revision 0dc3b072c1 (68 minutes ago), 2023-12-20 12:33:18 -0500
    • Engine revision c70f0a495a
    • Dart version 3.3.0 (build 3.3.0-244.0.dev)
    • DevTools version 2.31.0-dev.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/gspencer/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • ANDROID_HOME = /Users/gspencer/Library/Android/sdk
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.0.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15A507
    • CocoaPods version 1.14.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)

[✓] Android Studio (version 4.0)
    • Android Studio at /Users/gspencer/Library/Application
      Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] IntelliJ IDEA Community Edition (version 2022.1.3)
    • IntelliJ at /Applications/IntelliJ IDEA CE.app
    • Flutter plugin version 70.0.4
    • Dart plugin version 221.5921.27

[✓] VS Code (version 1.85.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.78.0

[✓] Connected device (2 available)
    • macOS (desktop) • macos  • darwin-arm64   • macOS 14.2 23C64 darwin-arm64
    • Chrome (web)    • chrome • web-javascript • Google Chrome 120.0.6099.109

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@gspencergoog
Copy link
Contributor Author

Oh, and the assets-for-api-docs generator isn't really meant to be run against anything except for the latest main (or master: they're the same), so running it against stable isn't intended to work.

@paldepind
Copy link
Contributor

Thanks for the reply @gspencergoog. I got it working with the latest master after updating my fork and rebuilding. I've created #233 to make the documentation a bit more clear in this regard. I misremembered and thought that had used the script with a released Flutter version in the past.

auto-submit bot pushed a commit that referenced this pull request Feb 8, 2024
Per #229 (comment) the generate script is intended to be used with the most recent development version of Flutter. As far as I can tell this is not mentioned in the readme�so this PR adds that :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants