-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to new Flutter version APIs, fix errors. #229
Conversation
5ddb923
to
71701c9
Compare
8126e98
to
cac0dc9
Compare
auto label is removed for flutter/assets-for-api-docs/229, Failed to merge flutter/assets-for-api-docs/229 with Pull request flutter/assets-for-api-docs/229 could not be merged: Required status check "WIP" is expected.. |
auto label is removed for flutter/assets-for-api-docs/229, Failed to merge flutter/assets-for-api-docs/229 with Pull request flutter/assets-for-api-docs/229 could not be merged: Required status check "WIP" is expected.. |
1067051
to
4be80a8
Compare
auto label is removed for flutter/assets-for-api-docs/229, Failed to merge flutter/assets-for-api-docs/229 with Pull request flutter/assets-for-api-docs/229 could not be merged: Required status check "WIP" is expected.. |
Updates the assets after fixing code in #229 I've done a check of all of the PNGs, and spot checked the videos.
Perhaps I'm doing something wrong, but I can't figure out how to generate the diagrams after this change. From this PR I also tried running the script with the latest Flutter from master bug I get a bunch of compilation errors. |
Huh. I'll check into it. |
@paldepind Well, I'm able to build and run I'd try cleaning up your git repo with something like My flutter doctor -v
|
Oh, and the assets-for-api-docs generator isn't really meant to be run against anything except for the latest main (or master: they're the same), so running it against |
Thanks for the reply @gspencergoog. I got it working with the latest master after updating my fork and rebuilding. I've created #233 to make the documentation a bit more clear in this regard. I misremembered and thought that had used the script with a released Flutter version in the past. |
Per #229 (comment) the generate script is intended to be used with the most recent development version of Flutter. As far as I can tell this is not mentioned in the readme�so this PR adds that :)
Description
This fixes some errors that have crept in with some Flutter API changes, and upgrades all of the pubspec packages to newer versions.
It also fixes some some overflow layout issues, and updates the platform shims for all of the packages.