feat: Various cleanups on Android (#509)

* feat: Various cleanups on Android

* changelog merge

Author: ened

CHANGELOG.md

@@ -1,3 +1,8 @@
+# next
+
+* Android: Removed jetifier
+* Android: Removed V1 plugin APIs - this is now a Android V2 plugin only
+
 # 0.5.2
 
 * Android: Bump to workmanager 2.8.1

android/build.gradle

@@ -36,7 +36,7 @@ android {
     defaultConfig {
         compileSdk 33
         minSdkVersion 19
-        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
+        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
     lintOptions {
         disable 'InvalidPackage'

android/gradle.properties

@@ -1,4 +1,4 @@
 org.gradle.jvmargs=-Xmx1536M
 
 android.useAndroidX=true
-android.enableJetifier=true
+android.enableJetifier=false

android/src/main/AndroidManifest.xml

@@ -1,2 +1,3 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android" package="dev.fluttercommunity.workmanager">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+    <uses-permission android:name="android.permission.POST_NOTIFICATIONS"/>
 </manifest>

android/src/main/kotlin/dev/fluttercommunity/workmanager/BackgroundWorker.kt

@@ -94,9 +94,6 @@ class BackgroundWorker(
                 )
             }
 
-            // Backwards compatibility with v1. We register all the user's plugins.
-            WorkmanagerPlugin.pluginRegistryCallback?.registerWith(ShimPluginRegistry(engine!!))
-
             engine?.let { engine ->
                 backgroundChannel = MethodChannel(engine.dartExecutor, BACKGROUND_CHANNEL_NAME)
                 backgroundChannel.setMethodCallHandler(this@BackgroundWorker)

android/src/main/kotlin/dev/fluttercommunity/workmanager/WorkmanagerPlugin.kt

@@ -4,7 +4,6 @@ import android.content.Context
 import io.flutter.embedding.engine.plugins.FlutterPlugin
 import io.flutter.plugin.common.BinaryMessenger
 import io.flutter.plugin.common.MethodChannel
-import io.flutter.plugin.common.PluginRegistry
 
 class WorkmanagerPlugin : FlutterPlugin {
 
@@ -30,24 +29,4 @@ class WorkmanagerPlugin : FlutterPlugin {
         methodChannel = null
         workmanagerCallHandler = null
     }
-
-    companion object {
-        var pluginRegistryCallback: PluginRegistry.PluginRegistrantCallback? = null
-
-        @JvmStatic
-        fun registerWith(registrar: PluginRegistry.Registrar) {
-            val plugin = WorkmanagerPlugin()
-            plugin.onAttachedToEngine(registrar.context(), registrar.messenger())
-            registrar.addViewDestroyListener {
-                plugin.onDetachedFromEngine()
-                false
-            }
-        }
-
-        @Deprecated(message = "Use the Android v2 embedding method.")
-        @JvmStatic
-        fun setPluginRegistrantCallback(pluginRegistryCallback: PluginRegistry.PluginRegistrantCallback) {
-            Companion.pluginRegistryCallback = pluginRegistryCallback
-        }
-    }
 }

example/android/app/build.gradle

@@ -42,7 +42,7 @@ android {
         targetSdkVersion 33
         versionCode flutterVersionCode.toInteger()
         versionName flutterVersionName
-        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
+        testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }
 
     buildTypes {
@@ -76,6 +76,6 @@ flutter {
 dependencies {
     implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
     testImplementation 'junit:junit:4.13.2'
-    androidTestImplementation 'androidx.test:runner:1.5.2'
-    androidTestImplementation 'androidx.test.espresso:espresso-core:3.5.1'
+    androidTestImplementation 'androidx.test:runner:1.2.0'
+    androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
 }