Skip to content

Commit 2925525

Browse files
authored
Upload frame_request_pending_latency [attempt #2] (flutter#135890)
These values are generated since flutter#135279, but I didn't know to add the new keys to this list to get them to upload. Failed to do so in flutter#135645, I believe the mistake there was putting them in `_kCommonScoreKeys`, which is also used in "E2E" tests, that don't get full trace data, only high level `FrameTiming` packets. Part of flutter#129150
1 parent 32bd280 commit 2925525

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

dev/devicelab/lib/tasks/perf_tests.dart

+3
Original file line numberDiff line numberDiff line change
@@ -1300,6 +1300,9 @@ class PerfTest {
13001300
'average_vsync_transitions_missed',
13011301
'90th_percentile_vsync_transitions_missed',
13021302
'99th_percentile_vsync_transitions_missed',
1303+
'average_frame_request_pending_latency',
1304+
'90th_percentile_frame_request_pending_latency',
1305+
'99th_percentile_frame_request_pending_latency',
13031306
if (measureCpuGpu && !isAndroid) ...<String>[
13041307
// See https://github.com/flutter/flutter/issues/68888
13051308
if (data['average_cpu_usage'] != null) 'average_cpu_usage',

dev/devicelab/test/perf_tests_test.dart

+6
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ void main() {
5858
'average_vsync_transitions_missed': 1,
5959
'90th_percentile_vsync_transitions_missed': 1,
6060
'99th_percentile_vsync_transitions_missed': 1,
61+
'average_frame_request_pending_latency': 0.1,
62+
'90th_percentile_frame_request_pending_latency': 0.1,
63+
'99th_percentile_frame_request_pending_latency': 0.1,
6164
};
6265
const String resultFileName = 'fake_result';
6366
void driveCallback(List<String> arguments) {
@@ -108,6 +111,9 @@ void main() {
108111
'90hz_frame_percentage': 0.4,
109112
'120hz_frame_percentage': 0.6,
110113
'illegal_refresh_rate_frame_count': 10,
114+
'average_frame_request_pending_latency': 0.1,
115+
'90th_percentile_frame_request_pending_latency': 0.1,
116+
'99th_percentile_frame_request_pending_latency': 0.1,
111117
};
112118
const String resultFileName = 'fake_result';
113119
void driveCallback(List<String> arguments) {

0 commit comments

Comments
 (0)