Skip to content

Commit 448a116

Browse files
authored
[Release] Update bots to expect new entitlements (flutter#153787)
When attempting to release the Flutter 3.24.1 hotfix, Flutter framework post submits failed due to the following error: ``` ���ERROR #1��������������������������������������������������������������������� � UNEXPECTED ERROR! � Exception: Found unexpected binary in cache: /Volumes/Work/s/w/ir/x/w/flutter/bin/cache/artifacts/engine/ios-release/extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter � #0 verifyExist (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:150:12) � <asynchronous suspension> � #1 verifyCodesignedTestRunner (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart:28:3) � <asynchronous suspension> � #2 _runFromList (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/utils.dart:601:5) � <asynchronous suspension> � #3 main (file:///Volumes/Work/s/w/ir/x/w/flutter/dev/bots/test.dart:125:5) � <asynchronous suspension> � � The test.dart script should be corrected to catch this error and call foundError(). � Some tests are likely to have been skipped. �������������������������������������������������������������������������������� ``` I've updated the tests to include the listed artifact. ### Open questions 1. Is it possible that the test failed only on the first binary? 2. Do we expect a need to add the remainder of the [entitlement changes](flutter/engine@c9b9d57)? 3. I am under the assumption that the bots pull from master and are not branch specific, is this a correct assumption? CC @christopherfujino @cbracken
1 parent 168579a commit 448a116

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

dev/bots/suite_runners/run_verify_binaries_codesigned_tests.dart

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ List<String> binariesWithoutEntitlements(String flutterRoot) {
100100
'artifacts/engine/ios-release/Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter',
101101
'artifacts/engine/ios-release/extension_safe/Flutter.xcframework/ios-arm64/Flutter.framework/Flutter',
102102
'artifacts/engine/ios-release/extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter',
103+
'artifacts/engine/ios-release/extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter',
103104
'artifacts/engine/ios/Flutter.xcframework/ios-arm64/Flutter.framework/Flutter',
104105
'artifacts/engine/ios/Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter',
105106
'artifacts/engine/ios/extension_safe/Flutter.xcframework/ios-arm64/Flutter.framework/Flutter',

0 commit comments

Comments
 (0)