Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux-shell: unable to format log msg #4860

Closed
garlick opened this issue Jan 17, 2023 · 0 comments · Fixed by #4878
Closed

flux-shell: unable to format log msg #4860

garlick opened this issue Jan 17, 2023 · 0 comments · Fixed by #4878

Comments

@garlick
Copy link
Member

garlick commented Jan 17, 2023

Problem: as noted in flux-framework/flux-pmix#76, flux_shell_log() gives up and prints this error when its internal buffer size is exceeded. It might be helpful to go ahead and log a partial buffer and tack a "+" on the end (or something) to indicate truncation.

garlick added a commit to garlick/flux-core that referenced this issue Jan 23, 2023
Problem: potentially useful shell log messages are lost if the
static log buffer size is exceeded.

If the message is too long, truncate it, add a '+', and continue on.
Don't treat this as an error.

Fixes flux-framework#4860
garlick added a commit to garlick/flux-core that referenced this issue Jan 23, 2023
Problem: potentially useful shell log messages are lost if the
static log buffer size is exceeded.

If the message is too long, truncate it, add a '+', and continue on.
Don't treat this as an error.

Fixes flux-framework#4860
@mergify mergify bot closed this as completed in #4878 Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant