Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flux-jobs: should --include imply -A (all users) option #6585

Open
chu11 opened this issue Jan 28, 2025 · 1 comment
Open

flux-jobs: should --include imply -A (all users) option #6585

chu11 opened this issue Jan 28, 2025 · 1 comment
Assignees
@chu11

Comments

@chu11
Copy link
Member

chu11 commented Jan 28, 2025

Since --include is mostly about seeing who is running on what nodes, it should probably imply looking through all user's jobs.

This reminds me of this prior issue, just a subtle "what is the right approach to combos of options?" question

#5142
@grondo
Copy link
Contributor

grondo commented Jan 28, 2025 •
edited
Loading

I agree -i, --include should imply -A (this even confused me recently), though as you note it can get a bit confusing and subtle. I was thinking maybe any filter-like option should imply -A, but that may be surprising with options like --name.

@chu11 chu11 self-assigned this Feb 13, 2025
chu11 added a commit to chu11/flux-core that referenced this issue Feb 14, 2025
@chu11
flux-jobs: fitler against all users with --include
adfca1a 
Problem: The --include function is predominantly used for finding
jobs on specific hosts.  This implies that the -A option is set (i.e.
filter on all user jobs) but it is currently not.  This can be
confusing to users wondering why --include isn't finding any jobs
running on specific hosts.

Solution: If the user did not specify filtering on a specific user
with --user, then assume all user jobs (i.e. -A or --user=all) will
be checked when --include is specified.

Fixes flux-framework#6585
chu11 added a commit to chu11/flux-core that referenced this issue Feb 14, 2025
@chu11
flux-jobs: filter against all users with --include
af9af34 
Problem: The --include option is predominantly used for finding
jobs on specific hosts.  This implies that the -A option is set (i.e.
filter on all user jobs) but it is currently not.  This can be
confusing to users wondering why --include isn't finding any jobs
running on specific hosts.

Solution: If the user did not specify filtering on a specific user
with --user, then assume all user jobs (i.e. -A or --user=all) will
be checked when --include is specified.

Fixes flux-framework#6585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chu11 @grondo