Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: remove fence support #6587

Closed
chu11 opened this issue Jan 29, 2025 · 0 comments
Closed

kvs: remove fence support #6587

chu11 opened this issue Jan 29, 2025 · 0 comments
Assignees

Comments

@chu11
Copy link
Member

chu11 commented Jan 29, 2025

Per discussion in #6112, the only use of the KVS fence is a non-default (and seemingly unused) option in the shell PMI plugin.

Removal of the KVS fence support could lead to a lot of cleanup in the KVS, most notably the transaction code is effectively no longer needed, since all transactions will be from a single request.

#6112 would be closed as a result

Lets give it a shot :-)

@chu11 chu11 self-assigned this Jan 29, 2025
chu11 added a commit to chu11/flux-core that referenced this issue Jan 30, 2025
Problem: The KVS fence implementation is virtually unused.  It also
has the potential for denial-of-service attacks.  Its implementation
is also quite "one off" within the KVS, limiting some ability to refactor
the code.  For all these reasons, it should be removed.  If fence-like
behavior is ever needed again in the future, it should be implemented
as a stand alone module on top of the KVS.

Solution: Remove all fence support in the KVS.

Fixes flux-framework#6587
chu11 added a commit to chu11/flux-core that referenced this issue Jan 30, 2025
Problem: The KVS fence implementation is virtually unused.  It also
has the potential for denial-of-service attacks.  Its implementation
is also quite "one off" within the KVS, limiting some ability to refactor
the code.  For all these reasons, it should be removed.  If fence-like
behavior is ever needed again in the future, it should be implemented
as a stand alone module/service on top of the KVS.

Solution: Remove all fence support in the KVS.

Fixes flux-framework#6587
@mergify mergify bot closed this as completed in 5318a8d Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant