Merge pull request #794 from aryan9600/fix-bitbucket-auth

hiddeco · web-flow · commit bc28ad5d1b3d · 2022-06-23T11:44:59.000+02:00
diff --git a/pkg/git/libgit2/managed/http.go b/pkg/git/libgit2/managed/http.go
@@ -279,7 +279,7 @@ func createClientRequest(targetURL string, action git2go.SmartServiceAction,
 
 	// Apply authentication and TLS settings to the HTTP transport.
 	if authOpts != nil {
-		if len(authOpts.Username) > 0 {
+		if authOpts.Username != "" && authOpts.Password != "" {
 			req.SetBasicAuth(authOpts.Username, authOpts.Password)
 		}
 		if len(authOpts.CAFile) > 0 {

Original file line number	Diff line number	Diff line change
`@@ -279,7 +279,7 @@ func createClientRequest(targetURL string, action git2go.SmartServiceAction,`
`279`	`279`
`280`	`280`	`// Apply authentication and TLS settings to the HTTP transport.`
`281`	`281`	`if authOpts != nil {`
`282`		`- if len(authOpts.Username) > 0 {`
	`282`	`+ if authOpts.Username != "" && authOpts.Password != "" {`
`283`	`283`	`req.SetBasicAuth(authOpts.Username, authOpts.Password)`
`284`	`284`	`}`
`285`	`285`	`if len(authOpts.CAFile) > 0 {`