fix: Print strings.Builder by calling String() explicitly.

octo · octo · commit fa3022443ce5 · 2024-07-05T15:55:32.000+02:00
The `String()` method is only defined for the pointer receiver.

Signed-off-by: Florian Forster &lt;fforster@gitlab.com&gt;
diff --git a/internal/controller/gitrepository_controller.go b/internal/controller/gitrepository_controller.go
@@ -1027,7 +1027,7 @@ func (r *GitRepositoryReconciler) verifySignature(ctx context.Context, obj *sour
 	reason := meta.SucceededReason
 	mode := obj.Spec.Verification.GetMode()
 	obj.Status.SourceVerificationMode = &mode
-	conditions.MarkTrue(obj, sourcev1.SourceVerifiedCondition, reason, "%v", message)
+	conditions.MarkTrue(obj, sourcev1.SourceVerifiedCondition, reason, "%s", message.String())
 	r.eventLogf(ctx, obj, eventv1.EventTypeTrace, reason, message.String())
 	return sreconcile.ResultSuccess, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -1027,7 +1027,7 @@ func (r GitRepositoryReconciler) verifySignature(ctx context.Context, obj sour`
`1027`	`1027`	`reason := meta.SucceededReason`
`1028`	`1028`	`mode := obj.Spec.Verification.GetMode()`
`1029`	`1029`	`obj.Status.SourceVerificationMode = &mode`
`1030`		`- conditions.MarkTrue(obj, sourcev1.SourceVerifiedCondition, reason, "%v", message)`
	`1030`	`+ conditions.MarkTrue(obj, sourcev1.SourceVerifiedCondition, reason, "%s", message.String())`
`1031`	`1031`	`r.eventLogf(ctx, obj, eventv1.EventTypeTrace, reason, message.String())`
`1032`	`1032`	`return sreconcile.ResultSuccess, nil`
`1033`	`1033`	`}`