fix: sim freezes on load in 2024 (#10397)

* fix: potentially huge deltaTime in `useUpdate`

* chore: changelog

* chore: move changelog entry to 0.14

(cherry picked from commit c5c4573)

Author: Benjozork

.github/CHANGELOG.md

@@ -156,6 +156,7 @@
 1. [A32NX] Enable mouse drag for knobs in lock mode - @heclak (Heclak)
 1. [A32NX] Fix some knobs snapping back to start position when turned to max value - @heclak (Heclak)
 1. [ND] Fix terrain display smearing issue - @flogross89 (floridude)
+1. [MISC] Prevent long sim freezes in some scenarios in MSFS 2024 - @Benjozork (Benjamin Dupont)
 
 ## 0.13.0
 

fbw-common/src/systems/instruments/src/BAT/BatDisplay.tsx

@@ -49,6 +49,8 @@ export const BatDisplay = ({ batteryNumber, blankWhenOff = false, x, y }) => {
   // It's possible that for example the lights test is turned off mid-cycle and we end up rendering 87.6, as the last
   // two digits were updated before the first one.
   useUpdate((deltaTime) => {
+    // FIXME this should probably use simulation time, not deltaTime
+
     const displayValue = getDisplayValue();
 
     // only update one digit at a time

fbw-common/src/systems/instruments/src/react/hooks.tsx

@@ -3,20 +3,26 @@
 //
 // SPDX-License-Identifier: GPL-3.0
 
-import React from 'react';
+import React, { useRef } from 'react';
 import { GenericDataListenerSync } from '../../../shared/src/GenericDataListenerSync';
 import { getRootElement } from '../defaults';
 
 export const useUpdate = (handler: (deltaTime: number) => void) => {
+  const lastTime = useRef(Date.now());
+
   // Logic based on https://usehooks.com/useEventListener/
   const savedHandler = React.useRef(handler);
   React.useEffect(() => {
     savedHandler.current = handler;
   }, [handler]);
 
   React.useEffect(() => {
-    const wrappedHandler = (event: CustomEvent) => {
-      savedHandler.current(event.detail);
+    const wrappedHandler = () => {
+      const now = Date.now();
+
+      savedHandler.current(now - lastTime.current);
+
+      lastTime.current = now;
     };
 
     getRootElement().addEventListener('update', wrappedHandler);