Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Formatting issues #61

Closed
Craftefix opened this issue Jul 1, 2024 · 5 comments
Closed

[Bug]: Formatting issues #61

Craftefix opened this issue Jul 1, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Craftefix
Copy link

Description

When using /pp install it doesnt filter for special characters so it has some issues with folders and filesystems

Minimal Reproduction

1./pp install Plan | Player Analytics
A temporary "fix" is using the -byID argunent

2./pp install eBackup - Simple and reliable backups for your server! Supports FTP/SFTP!
This always will save the plugin in eBackup - Simple and reliable backups for your server! Supports _FTP with the jar named SFTP.jar

Exception or Error

This bug will eventually create issues, especcially with feature #59 where the file could be saved in the unix/linux root dir "/" or user dir "~/"
When the plugin has a " | " in its name it ignores all arguments behind it, and says its the wrong source.
Also spaces can create issues with some plugins

Dump

https://mclo.gs/0VKWqht

@Craftefix Craftefix added the bug Something isn't working label Jul 1, 2024
@Craftefix
Copy link
Author

The filder issue with ebackup got patched, but now it doesnt want to install at all, bc of a wrong source argunent

@MLGPenguin
Copy link
Member

This is a duplicate of both #51 and #58

@Craftefix
Copy link
Author

Yikes sorry for the work

@Dawsson
Copy link
Member

Dawsson commented Jul 1, 2024

2 is fixed

@MLGPenguin
Copy link
Member

closes #51 and closes #58

Fixed in latest snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants