Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Document usage of dynamic log links #6285

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

fg91
Copy link
Member

@fg91 fg91 commented Feb 27, 2025

Why are the changes needed?

Allowing to configure custom log links for specific tasks has been a widely requested feature, see e.g. here or here.

So-called "dynamic log links" which were introduced for this purpose are now used for instance by the wandb or vscode plugins.

How these dynamic log links can be used is not yet documented in the Configuring logging links in the UI page, this PR adds an explanation.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@fg91 fg91 requested a review from ppiegaze as a code owner February 27, 2025 19:37
@flyte-bot
Copy link
Collaborator

Code Review Agent Run Status

  • Limitations and other issues: ❌ Failure - The AI Code Review Agent skipped reviewing this change because it is configured to exclude certain pull requests based on the source/target branch or the pull request status. You can change the settings here, or contact the agent instance creator at [email protected].

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.82%. Comparing base (5fe7a73) to head (df11707).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6285   +/-   ##
=======================================
  Coverage   33.82%   33.82%           
=======================================
  Files        1329     1329           
  Lines      147791   147791           
=======================================
  Hits        49991    49991           
  Misses      92961    92961           
  Partials     4839     4839           
Flag Coverage Δ
unittests-datacatalog 48.01% <ø> (ø)
unittests-flyteadmin 50.11% <ø> (ø)
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 58.09% <ø> (ø)
unittests-flyteidl 6.78% <ø> (ø)
unittests-flyteplugins 49.01% <ø> (ø)
unittests-flytepropeller 36.52% <ø> (ø)
unittests-flytestdlib 50.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@eapolinario eapolinario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much.

@eapolinario eapolinario enabled auto-merge (squash) February 27, 2025 19:41
@eapolinario eapolinario merged commit 37386ba into master Feb 27, 2025
51 checks passed
@eapolinario eapolinario deleted the fg91/doc/dynamic-log-links branch February 27, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants