Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible go lang exec.Command pipe/wait race #1

Open
skinowski opened this issue Jul 11, 2018 · 1 comment
Open

possible go lang exec.Command pipe/wait race #1

skinowski opened this issue Jul 11, 2018 · 1 comment
Labels
bug Something isn't working

Comments

@skinowski
Copy link
Member

Likely a bug, cmd.Wait() should not be called before all I/O is completed on stderr:

https://github.com/fnproject/hotwrap/blob/master/hotwrap.go#L78

(See: https://golang.org/pkg/os/exec/#Cmd.StderrPipe)

@zootalures zootalures added the bug Something isn't working label Jul 11, 2018
@zootalures
Copy link
Member

Thanks good spot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants