MODLD-940: Allow Import of Authority Records Without LCCN (#403)

* MODLD-940: Allow Import of Authority Records Without LCCN

* MODLD-940: Update AuthorityAssignmentControllerIT to validate assignment of FAST authorities

Author: pkjacob

NEWS.md

@@ -79,6 +79,7 @@
 - New endpoints for workspace profile settings [MODLD-936](https://folio-org.atlassian.net/browse/MODLD-936)
 - MOCKED_RESOURCE type handling and validation [MODLD-789](https://folio-org.atlassian.net/browse/MODLD-789)
 - Preserve ACCESSIBILITY_NOTE (MARC 532) when an Instance is saved [MODLD-728](https://folio-org.atlassian.net/browse/MODLD-728)
+- Allow Import of Authority Records Without LCCN [MODLD-940](https://folio-org.atlassian.net/browse/MODLD-940)
 
 ## 1.0.4 (04-24-2025)
 - Work Edit form - Instance read-only section: "Notes about the instance" data is not shown [MODLD-716](https://folio-org.atlassian.net/browse/MODLD-716)

src/main/java/org/folio/linked/data/integration/kafka/listener/handler/srs/SourceRecordDomainEventHandlerImpl.java

@@ -8,7 +8,6 @@
 import static org.folio.linked.data.domain.dto.SourceRecordType.MARC_BIB;
 import static org.folio.linked.data.util.Constants.STANDALONE_PROFILE;
 import static org.folio.linked.data.util.JsonUtils.hasElementByJsonPath;
-import static org.folio.linked.data.util.LccnUtils.hasLccn;
 
 import java.util.Set;
 import lombok.RequiredArgsConstructor;
@@ -48,7 +47,7 @@ public void handle(SourceRecordDomainEvent event, SourceRecordType recordType) {
     if (notProcessableEvent(event, recordType)) {
       return;
     }
-    if (isAuthorityEventWithLccn(event, recordType)) {
+    if (recordType == MARC_AUTHORITY) {
       saveAuthorities(event);
     } else if (isLinkedDataBibCreateEvent(event, recordType)) {
       saveAdminMetadata(event);
@@ -89,11 +88,6 @@ private void saveAuthority(Resource resource, SourceRecordDomainEvent event) {
     }
   }
 
-  private boolean isAuthorityEventWithLccn(SourceRecordDomainEvent event, SourceRecordType recordType) {
-    return recordType == MARC_AUTHORITY
-      && hasLccn(event.getEventPayload().getParsedRecord().getContent());
-  }
-
   private boolean isLinkedDataBibCreateEvent(SourceRecordDomainEvent event, SourceRecordType recordType) {
     return recordType == MARC_BIB
       && event.getEventType() == SOURCE_RECORD_CREATED

src/main/java/org/folio/linked/data/service/resource/marc/ResourceMarcAuthorityServiceImpl.java

@@ -4,11 +4,9 @@
 import static java.util.Optional.ofNullable;
 import static org.folio.ld.dictionary.PredicateDictionary.REPLACED_BY;
 import static org.folio.linked.data.domain.dto.AssignmentCheckResponseDto.InvalidAssignmentReasonEnum.NOT_VALID_FOR_TARGET;
-import static org.folio.linked.data.domain.dto.AssignmentCheckResponseDto.InvalidAssignmentReasonEnum.NO_LCCN;
 import static org.folio.linked.data.domain.dto.AssignmentCheckResponseDto.InvalidAssignmentReasonEnum.UNSUPPORTED_MARC;
 import static org.folio.linked.data.util.Constants.MSG_NOT_FOUND_IN;
 import static org.folio.linked.data.util.JsonUtils.writeValueAsString;
-import static org.folio.linked.data.util.LccnUtils.hasLccn;
 import static org.folio.linked.data.util.ResourceUtils.setPreferred;
 
 import com.fasterxml.jackson.databind.ObjectMapper;
@@ -79,10 +77,6 @@ public Optional<Resource> fetchAuthorityOrCreateByInventoryId(String inventoryId
 
   @Override
   public AssignmentCheckResponseDto validateAuthorityAssignment(String marc, AssignAuthorityTarget target) {
-    if (!hasLccn(marc)) {
-      return new AssignmentCheckResponseDto(false).invalidAssignmentReason(NO_LCCN);
-    }
-
     return marcAuthority2ldMapper.fromMarcJson(marc)
       .stream()
       .findFirst()

src/main/java/org/folio/linked/data/util/LccnUtils.java

@@ -1,24 +1,16 @@
 package org.folio.linked.data.util;
 
 import static org.apache.commons.collections4.CollectionUtils.isEmpty;
-import static org.folio.linked.data.util.JsonUtils.hasElementByJsonPath;
 
 import lombok.experimental.UtilityClass;
 import org.folio.linked.data.domain.dto.IdentifierRequest;
 
 @UtilityClass
 public class LccnUtils {
-
-  private static final String LCCN_JSON_PATH = "$.fields[*].010.subfields[*].a";
-
   public static boolean isCurrent(IdentifierRequest lccnRequest) {
     return isEmpty(lccnRequest.getStatus()) || lccnRequest.getStatus()
       .stream()
       .flatMap(status -> status.getLink().stream())
       .anyMatch(link -> link.endsWith("current"));
   }
-
-  public static boolean hasLccn(String marcJson) {
-    return hasElementByJsonPath(marcJson, LCCN_JSON_PATH);
-  }
 }

src/main/resources/swagger.api/schema/assignmentCheckResponseDto.json

@@ -9,7 +9,7 @@
     },
     "invalidAssignmentReason": {
       "type": "string",
-      "enum": ["UNSUPPORTED_MARC", "NO_LCCN", "NOT_VALID_FOR_TARGET"],
+      "enum": ["UNSUPPORTED_MARC", "NOT_VALID_FOR_TARGET"],
       "description": "Indicates the reason why the assignment is not valid. Only present if 'validAssignment' is false."
     }
   },

src/test/java/org/folio/linked/data/e2e/AuthorityAssignmentControllerIT.java

@@ -39,6 +39,7 @@ class AuthorityAssignmentControllerIT {
     "samples/marc/authority_jurisdiction.json, true",
     "samples/marc/authority_concept_meeting.json, false",
     "samples/marc/non_authority.json, false",
+    "samples/marc/authority_person_fast.json, true",
   })
   void authorityAssignmentCheck(String marcFile, String expectedResponse) throws Exception {
     // given

src/test/java/org/folio/linked/data/service/resource/marc/ResourceMarcAuthorityServiceAuthorityAsssignmentTest.java

@@ -5,7 +5,6 @@
 import static org.folio.ld.dictionary.ResourceTypeDictionary.FORM;
 import static org.folio.ld.dictionary.ResourceTypeDictionary.PERSON;
 import static org.folio.linked.data.domain.dto.AssignmentCheckResponseDto.InvalidAssignmentReasonEnum.NOT_VALID_FOR_TARGET;
-import static org.folio.linked.data.domain.dto.AssignmentCheckResponseDto.InvalidAssignmentReasonEnum.NO_LCCN;
 import static org.folio.linked.data.domain.dto.AssignmentCheckResponseDto.InvalidAssignmentReasonEnum.UNSUPPORTED_MARC;
 import static org.folio.linked.data.service.resource.marc.AssignAuthorityTarget.CREATOR_OF_WORK;
 import static org.folio.linked.data.service.resource.marc.AssignAuthorityTarget.SUBJECT_OF_WORK;
@@ -92,17 +91,6 @@ void validateAuthorityAssignment_shouldReturnFalse_ifAuthorityIsEmpty() {
     assertThat(result.getInvalidAssignmentReason()).isEqualTo(UNSUPPORTED_MARC);
   }
 
-  @ParameterizedTest
-  @MethodSource("noLccnMarcRecords")
-  void validateAuthorityAssignment_shouldReturnFalse_ifNoLccn(String marc) {
-    // when
-    var result = resourceMarcAuthorityService.validateAuthorityAssignment(marc, CREATOR_OF_WORK);
-
-    // then
-    assertThat(result.getValidAssignment()).isFalse();
-    assertThat(result.getInvalidAssignmentReason()).isEqualTo(NO_LCCN);
-  }
-
   private static Stream<Arguments> authorityAssignmentArguments_validTargets() {
     return Stream.of(
       Arguments.of(Set.of(PERSON), CREATOR_OF_WORK),
@@ -118,24 +106,4 @@ private static Stream<Arguments> authorityAssignmentArguments_invalidTargets() {
       Arguments.of(Set.of(CONCEPT, FORM, PERSON), SUBJECT_OF_WORK)
     );
   }
-
-  private static Stream<Arguments> noLccnMarcRecords() {
-    return Stream.of(
-      Arguments.of("""
-                {
-                   "fields":[
-                      { "100":{ "subfields":[ { "a":"Person with no LCCN" } ] } }
-                   ]
-                }
-              """),
-      Arguments.of("""
-                {
-                   "fields":[
-                      { "010":{ "subfields":[ { "z":"no2023016747" } ] } },
-                      { "100":{ "subfields":[ { "a":"Person with cancelled LCCN" } ] } }
-                   ]
-                }
-              """)
-    );
-  }
 }

src/test/resources/samples/marc/authority_person_fast.json

@@ -0,0 +1,27 @@
+{
+  "fields" : [ {
+    "001":"fst1234567890"
+  }, {
+    "100" : {
+      "subfields" : [ {
+        "a" : "aValue"
+      }, {
+        "b" : "bValue"
+      }, {
+        "c" : "cValue1"
+      }, {
+        "c" : "cValue2"
+      }, {
+        "d" : "dValue"
+      }, {
+        "j" : "jValue1"
+      }, {
+        "j" : "jValue2"
+      }, {
+        "q" : "qValue"
+      } ],
+      "ind1" : " ",
+      "ind2" : " "
+    }
+  } ]
+}