You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm playing around with a fork of the project and having recently rebased with master I have noticed that the .prettierrc has been removed, this has meant that the default prettier behaviour for "singleQuote": false is now being applied to .js files. Conversely the .prettierignore file has been left and prettier is still setup as a devDependency. In order to not have the default prettier rules apply, I've had to switch to ESlint as my default formatter for the project, but this doesn't actually apply any rules as far as I can see.
Is the plan to not have any explicit formatting applied to the project, or is this a setup issue on my env (Using vscode as my IDE), or should there be a more explicit change to using a specific formatter (eg: ESlint over prettier) that I've not picked up on?
I'm also confused why all the scrips and contribution docs mention npm ... but there is a yarn.lock file. Perhaps this is part of why I'm also seeing #1586.
Your environment
pdfkit version: master
Node version: 20.12.0
Browser version (if applicable):
Operating System: macOS Sonoma 14.6.1
The text was updated successfully, but these errors were encountered:
Question
Description
I'm playing around with a fork of the project and having recently rebased with master I have noticed that the .prettierrc has been removed, this has meant that the default prettier behaviour for
"singleQuote": false
is now being applied to .js files. Conversely the .prettierignore file has been left and prettier is still setup as a devDependency. In order to not have the default prettier rules apply, I've had to switch to ESlint as my default formatter for the project, but this doesn't actually apply any rules as far as I can see.Is the plan to not have any explicit formatting applied to the project, or is this a setup issue on my env (Using vscode as my IDE), or should there be a more explicit change to using a specific formatter (eg: ESlint over prettier) that I've not picked up on?
I'm also confused why all the scrips and contribution docs mention
npm ...
but there is ayarn.lock
file. Perhaps this is part of why I'm also seeing #1586.Your environment
The text was updated successfully, but these errors were encountered: