Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier/ESlint formatting, removal of .prettierrc #1587

Closed
tr1stan opened this issue Jan 14, 2025 · 1 comment
Closed

Prettier/ESlint formatting, removal of .prettierrc #1587

tr1stan opened this issue Jan 14, 2025 · 1 comment

Comments

@tr1stan
Copy link

tr1stan commented Jan 14, 2025

Question

Description

I'm playing around with a fork of the project and having recently rebased with master I have noticed that the .prettierrc has been removed, this has meant that the default prettier behaviour for "singleQuote": false is now being applied to .js files. Conversely the .prettierignore file has been left and prettier is still setup as a devDependency. In order to not have the default prettier rules apply, I've had to switch to ESlint as my default formatter for the project, but this doesn't actually apply any rules as far as I can see.

Is the plan to not have any explicit formatting applied to the project, or is this a setup issue on my env (Using vscode as my IDE), or should there be a more explicit change to using a specific formatter (eg: ESlint over prettier) that I've not picked up on?

I'm also confused why all the scrips and contribution docs mention npm ... but there is a yarn.lock file. Perhaps this is part of why I'm also seeing #1586.

Your environment

  • pdfkit version: master
  • Node version: 20.12.0
  • Browser version (if applicable):
  • Operating System: macOS Sonoma 14.6.1
@liborm85
Copy link
Collaborator

File .prettierrc restored by 6603d6a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants