fixup! feat: optional id label for all metrics

damiankaminski-form3 · damiankaminski-form3 · commit ad760ba3cfe3 · 2024-02-22T17:39:52.000+01:00
diff --git a/internal/run/main_test.go b/internal/run/main_test.go
@@ -30,7 +30,7 @@ func TestMain(m *testing.M) {
 	if err != nil {
 		log.Fatal(err)
 	}
-	err = os.Setenv("PROMETHEUS_ID_LABEL", fakePrometheusID)
+	err = os.Setenv("PROMETHEUS_LABEL_ID", fakePrometheusID)
 	if err != nil {
 		log.Fatal(err)
 	}
diff --git a/internal/run/test_runner.go b/internal/run/test_runner.go
@@ -49,7 +49,7 @@ func NewRun(options options.RunOptions, t *api.Trigger) (*Run, error) {
 			run.pusher = run.pusher.Grouping("namespace", namespaceLabel)
 		}
 
-		idLabel := os.Getenv("PROMETHEUS_ID_LABEL")
+		idLabel := os.Getenv("PROMETHEUS_LABEL_ID")
 		if idLabel != "" {
 			run.pusher = run.pusher.Grouping("id", idLabel)
 		}

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ func TestMain(m *testing.M) {`
`30`	`30`	`if err != nil {`
`31`	`31`	`log.Fatal(err)`
`32`	`32`	`}`
`33`		`- err = os.Setenv("PROMETHEUS_ID_LABEL", fakePrometheusID)`
	`33`	`+ err = os.Setenv("PROMETHEUS_LABEL_ID", fakePrometheusID)`
`34`	`34`	`if err != nil {`
`35`	`35`	`log.Fatal(err)`
`36`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ func NewRun(options options.RunOptions, t api.Trigger) (Run, error) {`
`49`	`49`	`run.pusher = run.pusher.Grouping("namespace", namespaceLabel)`
`50`	`50`	`}`
`51`	`51`
`52`		`- idLabel := os.Getenv("PROMETHEUS_ID_LABEL")`
	`52`	`+ idLabel := os.Getenv("PROMETHEUS_LABEL_ID")`
`53`	`53`	`if idLabel != "" {`
`54`	`54`	`run.pusher = run.pusher.Grouping("id", idLabel)`
`55`	`55`	`}`