Merge pull request #45 from form3tech-oss/nl-return-interaction-not-found

feat: Add interaction not found error

Author: nicholas-lebrun-form3

internal/app/pactproxy/proxy.go

@@ -187,7 +187,7 @@ func (a *api) interactionsGetHandler(c echo.Context) error {
 	alias := c.Param("alias")
 	interaction, found := a.interactions.Load(alias)
 	if !found {
-		return c.JSON(http.StatusBadRequest, httpresponse.Errorf("interaction %q not found", alias))
+		return c.JSON(http.StatusNotFound, httpresponse.Errorf("interaction %q not found", alias))
 	}
 
 	return c.JSON(http.StatusOK, interaction)

internal/app/pactproxy/proxy_test.go

@@ -135,7 +135,7 @@ func TestInteractionsGetHandler(t *testing.T) {
 		{
 			name:         "interaction not found",
 			interactions: &Interactions{},
-			code:         http.StatusBadRequest,
+			code:         http.StatusNotFound,
 			body:         `{"error_message":"interaction \"test\" not found"}`,
 		},
 	} {

pkg/pactproxy/pactproxy.go

@@ -14,6 +14,8 @@ import (
 	log "github.com/sirupsen/logrus"
 )
 
+var InteractionNotFoundError = errors.New("interaction not found")
+
 type PactProxy struct {
 	client http.Client
 	url    string
@@ -144,6 +146,9 @@ func (p *PactProxy) ReadInteractionDetails(alias string) (*Interaction, error) {
 		return nil, errors.Wrap(err, "http get")
 	}
 	if res.StatusCode != http.StatusOK {
+		if res.StatusCode == http.StatusNotFound {
+			return nil, InteractionNotFoundError
+		}
 		return nil, errors.New("fail")
 	}
 	interaction := &Interaction{}