fix(lift): homepage was never provided under projectDetails when lifting

Author: travi

src/lifter.js

@@ -1,6 +1,6 @@
 import {fileTypes, mergeIntoExistingConfigFile} from '@form8ion/core';
 
-export default async function ({projectRoot, results: {projectDetails: {homepage} = {}, tags}}) {
+export default async function ({projectRoot, results: {homepage, tags}}) {
   await mergeIntoExistingConfigFile({
     format: fileTypes.YAML,
     path: `${projectRoot}/.github`,

src/lifter.test.js

@@ -15,10 +15,7 @@ describe('lifter', () => {
   it('should set properties in the settings file', async () => {
     const result = await lift({
       projectRoot,
-      results: {
-        projectDetails: {homepage},
-        tags
-      }
+      results: {homepage, tags}
     });
 
     expect(result).toEqual({});
@@ -58,20 +55,14 @@ describe('lifter', () => {
   it('should not result in an error when tags are not provided in the results', async () => {
     await lift({
       projectRoot,
-      results: {
-        projectDetails: {homepage}
-      }
+      results: {homepage}
     });
 
     expect(mergeIntoExistingConfigFile).toHaveBeenCalledWith({
       format: fileTypes.YAML,
       path: `${projectRoot}/.github`,
       name: 'settings',
-      config: {
-        repository: {
-          homepage
-        }
-      }
+      config: {repository: {homepage}}
     });
   });
 });

test/integration/features/lift.feature

@@ -2,21 +2,21 @@ Feature: Lift
 
   Scenario: Lift
     Given the GitHub repository settings are managed by the repository-settings app
-    And the scaffolder results include projectDetails
+    And the scaffolder results include homepage
     And the scaffolder results include tags
     When scaffolder results are processed
     Then properties are updated in the settings file
 
   Scenario: Lift w/o project details
     Given the GitHub repository settings are managed by the repository-settings app
     And the scaffolder results include tags
-    But the scaffolder results do not include projectDetails
+    But the scaffolder results do not include homepage
     When scaffolder results are processed
     Then properties are updated in the settings file
 
   Scenario: Lift w/o tags
     Given the GitHub repository settings are managed by the repository-settings app
-    And the scaffolder results include projectDetails
+    And the scaffolder results include homepage
     But the scaffolder results do not include tags
     When scaffolder results are processed
     Then properties are updated in the settings file
@@ -25,7 +25,7 @@ Feature: Lift
   Scenario: Lift w/ existing tags and new tags
     Given the GitHub repository settings are managed by the repository-settings app
     And the existing settings file includes existing tags
-    And the scaffolder results include projectDetails
+    And the scaffolder results include homepage
     And the scaffolder results include tags
     When scaffolder results are processed
     Then properties are updated in the settings file

test/integration/features/step_definitions/common-steps.js

@@ -45,7 +45,7 @@ When('scaffolder results are processed', async function () {
     await lift({
       projectRoot: this.projectRoot,
       results: {
-        projectDetails: this.projectDetails,
+        homepage: this.homepage,
         tags: this.tags
       }
     });

test/integration/features/step_definitions/results-steps.js

@@ -1,13 +1,12 @@
 import {Given} from '@cucumber/cucumber';
 import any from '@travi/any';
 
-Given('the scaffolder results do not include projectDetails', async function () {
+Given('the scaffolder results do not include homepage', async function () {
   return undefined;
 });
 
-Given('the scaffolder results include projectDetails', async function () {
+Given('the scaffolder results include homepage', async function () {
   this.homepage = any.url();
-  this.projectDetails = {homepage: this.homepage};
 });
 
 Given('the scaffolder results include tags', async function () {