Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disparity between IDL foxsi_get_output_image_cube and foxsi_get_output_2d_image #30

Open
ayshih opened this issue Nov 13, 2015 · 1 comment

Comments

@ayshih
Copy link
Contributor

ayshih commented Nov 13, 2015

It's weird that foxsi_get_output_image_cube performs a unit conversion from photons to counts (because it has awareness of energies and can determine effective areas) but foxsi_get_output_2d_image just convolves in the response of the optics so the output units are still photons (or whatever the units of the source map is).

@LinErinG
Copy link
Member

Although I agree this is a disparity, I think it's most useful this way. We want people to be able to make images without worrying about what the energy is. That way I can just make an image that will have X counts in it, where I can easily control X; this is quite useful for assessing image quality, etc. So the right way to think of it is that it's not actually starting out in photons at all. If you do want energy information included, then the image cube routine can be used for that. Alternatively, the 2d_image routine could include an energy keyword to specify energy only if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants