From f37f094ef5008ceaefbdae0049aa984757148ffe Mon Sep 17 00:00:00 2001
From: RitvikSardana <ritvik.sardana11@gmail.com>
Date: Mon, 3 Feb 2025 16:59:09 +0530
Subject: [PATCH] chore: code cleanup

---
 desk/src/components/ListViewBuilder.vue | 24 +++++-------------------
 desk/src/types.ts                       |  6 ------
 2 files changed, 5 insertions(+), 25 deletions(-)

diff --git a/desk/src/components/ListViewBuilder.vue b/desk/src/components/ListViewBuilder.vue
index cfffcc1b5..a232323c5 100644
--- a/desk/src/components/ListViewBuilder.vue
+++ b/desk/src/components/ListViewBuilder.vue
@@ -93,7 +93,7 @@
 </template>
 
 <script setup lang="ts">
-import { reactive, provide, computed, h } from "vue";
+import { reactive, provide, computed, h, ref } from "vue";
 import {
   createResource,
   ListView,
@@ -102,7 +102,6 @@ import {
   ListHeader,
   ListHeaderItem,
   ListSelectBanner,
-  Badge,
   FeatherIcon,
   Dropdown,
 } from "frappe-ui";
@@ -118,7 +117,7 @@ import { dayjs } from "@/dayjs";
 import ListRows from "./ListRows.vue";
 import { useScreenSize } from "@/composables/screen";
 import EmptyState from "./EmptyState.vue";
-import { BadgeStatus, View } from "@/types";
+import { View } from "@/types";
 
 interface P {
   options: {
@@ -200,8 +199,9 @@ const list = createResource({
     });
     return data;
   },
-  onSuccess: () => {
+  onSuccess: (data) => {
     list.params = defaultParams;
+    columns.value = data.columns;
   },
 });
 
@@ -213,7 +213,7 @@ const rows = computed(() => {
   }
   return list.data?.data;
 });
-const columns = computed(() => list.data?.columns);
+const columns = ref([]);
 
 function getGroupedByRows(listRows, groupByField) {
   let groupedRows = [];
@@ -383,20 +383,6 @@ provide("listViewActions", {
   reload,
 });
 
-function toggleFilter(filter) {
-  const currentFilterColumns = Object.keys(defaultParams.filters);
-  const selectedFilter = Object.keys(filter)[0];
-  const isFilterApplied = currentFilterColumns.includes(selectedFilter);
-  if (!isFilterApplied) {
-    applyFilters(filter);
-  } else {
-    // remove filter
-    const newFilters = { ...defaultParams.filters };
-    delete newFilters[selectedFilter];
-    applyFilters(newFilters);
-  }
-}
-
 function applyFilters(filters) {
   defaultParams.filters = { ...filters };
   list.submit({ ...defaultParams });
diff --git a/desk/src/types.ts b/desk/src/types.ts
index 189d8404f..646ed694c 100644
--- a/desk/src/types.ts
+++ b/desk/src/types.ts
@@ -257,12 +257,6 @@ export interface Category {
   children?: Article[];
 }
 
-// Badge
-export interface BadgeStatus {
-  label: string;
-  theme: string;
-}
-
 export interface View {
   view_type: string;
   group_by_field: string;