Skip to content

Commit 4ed93bd

Browse files
fix(Interview Feedback): type cast user input for "rating" field to float (backport #1799) (#1800)
(cherry picked from commit cb8ac7e) Co-authored-by: Viny Selopal <[email protected]>
1 parent 8bb057b commit 4ed93bd

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

hrms/hr/doctype/interview_feedback/interview_feedback.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def calculate_average_rating(self):
5757
total_rating = 0
5858
for d in self.skill_assessment:
5959
if d.rating:
60-
total_rating += d.rating
60+
total_rating += flt(d.rating)
6161

6262
self.average_rating = flt(
6363
total_rating / len(self.skill_assessment) if len(self.skill_assessment) else 0

hrms/hr/doctype/interview_feedback/test_interview_feedback.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def test_average_ratings_on_feedback_submission_and_cancellation(self):
4949
total_rating = 0
5050
for d in feedback_1.skill_assessment:
5151
if d.rating:
52-
total_rating += d.rating
52+
total_rating += flt(d.rating)
5353

5454
avg_rating = flt(
5555
total_rating / len(feedback_1.skill_assessment) if len(feedback_1.skill_assessment) else 0

0 commit comments

Comments
 (0)