Merge pull request #1557 from frappe/mergify/bp/version-14-hotfix/pr-1553

krantheman · web-flow · commit 516dcb7cf3ac · 2024-03-19T12:08:28.000+05:30
fix: don't update exchange rate for all references (backport #1553)
diff --git a/hrms/overrides/employee_payment_entry.py b/hrms/overrides/employee_payment_entry.py
@@ -44,7 +44,8 @@ def set_missing_ref_details(
 					d.reference_doctype, d.reference_name, self.party_account_currency
 				)
 
-				if ref_exchange_rate:
+				# Only update exchange rate when the reference is Journal Entry
+				if ref_exchange_rate and d.reference_doctype == "Journal Entry":
 					ref_details.update({"exchange_rate": ref_exchange_rate})
 
 				for field, value in ref_details.items():

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,8 @@ def set_missing_ref_details(`
`44`	`44`	`d.reference_doctype, d.reference_name, self.party_account_currency`
`45`	`45`	`)`
`46`	`46`
`47`		`- if ref_exchange_rate:`
	`47`	`+ # Only update exchange rate when the reference is Journal Entry`
	`48`	`+ if ref_exchange_rate and d.reference_doctype == "Journal Entry":`
`48`	`49`	`ref_details.update({"exchange_rate": ref_exchange_rate})`
`49`	`50`
`50`	`51`	`for field, value in ref_details.items():`