Skip to content

Commit e252e89

Browse files
fix: use reference name while updating exc rate (backport #1623) (#1634)
(cherry picked from commit a24fbd0) Co-authored-by: ruthra kumar <[email protected]>
1 parent 32abbc2 commit e252e89

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

hrms/overrides/employee_payment_entry.py

+7-3
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def set_missing_ref_details(
3131
self,
3232
force: bool = False,
3333
update_ref_details_only_for: list | None = None,
34-
ref_exchange_rate: float | None = None,
34+
reference_exchange_details: dict | None = None,
3535
) -> None:
3636
for d in self.get("references"):
3737
if d.allocated_amount:
@@ -45,8 +45,12 @@ def set_missing_ref_details(
4545
)
4646

4747
# Only update exchange rate when the reference is Journal Entry
48-
if ref_exchange_rate and d.reference_doctype == "Journal Entry":
49-
ref_details.update({"exchange_rate": ref_exchange_rate})
48+
if (
49+
reference_exchange_details
50+
and d.reference_doctype == reference_exchange_details.reference_doctype
51+
and d.reference_name == reference_exchange_details.reference_name
52+
):
53+
ref_details.update({"exchange_rate": reference_exchange_details.exchange_rate})
5054

5155
for field, value in ref_details.items():
5256
if d.exchange_gain_loss:

0 commit comments

Comments
 (0)