fix: filters on vehicle expenses report (#2440)

Author: asmitahase

hrms/hr/report/vehicle_expenses/vehicle_expenses.js

@@ -9,6 +9,20 @@ frappe.query_reports["Vehicle Expenses"] = {
 			options: ["Fiscal Year", "Date Range"],
 			default: ["Fiscal Year"],
 			reqd: 1,
+			on_change: () => {
+				let filter_based_on = frappe.query_report.get_filter_value("filter_based_on");
+
+				if (filter_based_on == "Fiscal Year") {
+					set_reqd_filter("fiscal_year", true);
+					set_reqd_filter("from_date", false);
+					set_reqd_filter("to_date", false);
+				}
+				if (filter_based_on == "Date Range") {
+					set_reqd_filter("fiscal_year", false);
+					set_reqd_filter("from_date", true);
+					set_reqd_filter("to_date", true);
+				}
+			},
 		},
 		{
 			fieldname: "fiscal_year",
@@ -17,21 +31,18 @@ frappe.query_reports["Vehicle Expenses"] = {
 			options: "Fiscal Year",
 			default: frappe.defaults.get_user_default("fiscal_year"),
 			depends_on: "eval: doc.filter_based_on == 'Fiscal Year'",
-			reqd: 1,
 		},
 		{
 			fieldname: "from_date",
 			label: __("From Date"),
 			fieldtype: "Date",
-			reqd: 1,
 			depends_on: "eval: doc.filter_based_on == 'Date Range'",
 			default: frappe.datetime.add_months(frappe.datetime.nowdate(), -12),
 		},
 		{
 			fieldname: "to_date",
 			label: __("To Date"),
 			fieldtype: "Date",
-			reqd: 1,
 			depends_on: "eval: doc.filter_based_on == 'Date Range'",
 			default: frappe.datetime.nowdate(),
 		},
@@ -49,3 +60,9 @@ frappe.query_reports["Vehicle Expenses"] = {
 		},
 	],
 };
+
+function set_reqd_filter(fieldname, is_reqd) {
+	let filter = frappe.query_report.get_filter(fieldname);
+	filter.df.reqd = is_reqd;
+	filter.refresh();
+}