From 0b9935aa8ec1bf84210980f519b1ddad8f769d50 Mon Sep 17 00:00:00 2001
From: Viny Selopal <52369157+vinyselopal@users.noreply.github.com>
Date: Wed, 22 May 2024 11:59:22 +0530
Subject: [PATCH] fix(Interview Feedback): type cast user input for "rating"
 field to float (#1799)

(cherry picked from commit cb8ac7e28c18c57d16ceee11feffd97707fdaa7a)
---
 hrms/hr/doctype/interview_feedback/interview_feedback.py      | 2 +-
 hrms/hr/doctype/interview_feedback/test_interview_feedback.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hrms/hr/doctype/interview_feedback/interview_feedback.py b/hrms/hr/doctype/interview_feedback/interview_feedback.py
index 1c1c2f8458..ed80f9a5c8 100644
--- a/hrms/hr/doctype/interview_feedback/interview_feedback.py
+++ b/hrms/hr/doctype/interview_feedback/interview_feedback.py
@@ -58,7 +58,7 @@ def calculate_average_rating(self):
 		total_rating = 0
 		for d in self.skill_assessment:
 			if d.rating:
-				total_rating += d.rating
+				total_rating += flt(d.rating)
 
 		self.average_rating = flt(
 			total_rating / len(self.skill_assessment) if len(self.skill_assessment) else 0
diff --git a/hrms/hr/doctype/interview_feedback/test_interview_feedback.py b/hrms/hr/doctype/interview_feedback/test_interview_feedback.py
index 6e9642a0e6..e9b9222669 100644
--- a/hrms/hr/doctype/interview_feedback/test_interview_feedback.py
+++ b/hrms/hr/doctype/interview_feedback/test_interview_feedback.py
@@ -49,7 +49,7 @@ def test_average_ratings_on_feedback_submission_and_cancellation(self):
 		total_rating = 0
 		for d in feedback_1.skill_assessment:
 			if d.rating:
-				total_rating += d.rating
+				total_rating += flt(d.rating)
 
 		avg_rating = flt(
 			total_rating / len(feedback_1.skill_assessment) if len(feedback_1.skill_assessment) else 0