From 25fce7e462e1c61a1cc98adf28f060adc4da2bf5 Mon Sep 17 00:00:00 2001 From: Mauricio Giadach Date: Wed, 29 May 2024 20:04:56 +0000 Subject: [PATCH] fix: prevent private pages from showing in sidebar --- wiki/wiki/doctype/wiki_page/wiki_page.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/wiki/wiki/doctype/wiki_page/wiki_page.py b/wiki/wiki/doctype/wiki_page/wiki_page.py index 797415c2..4a365673 100644 --- a/wiki/wiki/doctype/wiki_page/wiki_page.py +++ b/wiki/wiki/doctype/wiki_page/wiki_page.py @@ -317,6 +317,12 @@ def get_sidebar_items(self): continue wiki_page = frappe.get_doc("Wiki Page", sidebar_item.wiki_page) + + if not wiki_page.allow_guest: + permitted = frappe.has_permission(wiki_page.doctype, 'read', wiki_page) + if not permitted: + continue + if sidebar_item.parent_label not in sidebar: sidebar[sidebar_item.parent_label] = [ {