Skip to content

Commit b76cad4

Browse files
committed
perf: use cached docs everywhere
It's JUST read in cache before rendering, why load from DB again?
1 parent 6cb9205 commit b76cad4

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

wiki/wiki/doctype/wiki_page/wiki_page.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,9 @@ def get_context(self, context):
205205

206206
wiki_settings = frappe.get_single("Wiki Settings")
207207
wiki_space_name = frappe.get_value("Wiki Group Item", {"wiki_page": self.name}, "parent")
208-
wiki_space = frappe.get_doc("Wiki Space", wiki_space_name) if wiki_space_name else frappe._dict()
208+
wiki_space = (
209+
frappe.get_cached_doc("Wiki Space", wiki_space_name) if wiki_space_name else frappe._dict()
210+
)
209211

210212
context.no_cache = 0 # Changes will invalidate HTML cache
211213
context.navbar_search = wiki_settings.add_search_bar
@@ -303,7 +305,7 @@ def get_sidebar_items(self):
303305
if sidebar_item.hide_on_sidebar:
304306
continue
305307

306-
wiki_page = frappe.get_doc("Wiki Page", sidebar_item.wiki_page)
308+
wiki_page = frappe.get_cached_doc("Wiki Page", sidebar_item.wiki_page)
307309

308310
permitted = wiki_page.allow_guest or frappe.session.user != "Guest"
309311
if not permitted:
@@ -545,7 +547,7 @@ def get_source(resolved_route, jenv):
545547

546548
@frappe.whitelist(allow_guest=True)
547549
def get_sidebar_for_page(wiki_page):
548-
sidebar = frappe.get_doc("Wiki Page", wiki_page).get_sidebar_items()
550+
sidebar = frappe.get_cached_doc("Wiki Page", wiki_page).get_sidebar_items()
549551
return sidebar
550552

551553

0 commit comments

Comments
 (0)