-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring x-rate upstream #16
Comments
Hey Julien, Yeah, totally! I'm a bit rusty on Golang (haven't really coded anything in almost 2 years), but the concept and implementation are pretty simple, so I'm happy to give it a go. Let me know what you need and I will try to oblige. Cheers! |
For now the idea would be to put the approaches described in the upstream issue in a clear google doc instead of a github issue. once it is done, we can start discussing a bit easily. Note that I want to solve this issue, so the goal is really not to make you lose your time; the goal is to have this actually implemented quite soon. |
Should I go ahead and start that document (when I can find the time) or would you do it? (E.g. if there's some structure / process it must follow rather than a free-form proposal.) |
I have shared an empty design doc with you, you should be able to use it and move forward. Thanks |
Finally found the time to go through the whole document. I had to rush through it towards the end (or it might have taken me another month to get back to it) but I believe I've done a mostly decent job. Will try to address any comments as they come, but it may take some time to do so. |
Thanks a lot! |
Did another pass a few days ago, please let me know if you need anything specific on my part. |
@roidelapluie ? :) |
Hello,
I'd like to know if you would be interested into bringing x-rate upstream in Prometheus, behind a feature flag? Exact details would be TBD, but we are open to this idea and would welcome a formal proposal to move forward in this direction.
if you want to contribute it, we could re-analyze your proposals with a fresh eye and find the best outcome for the community.
thanks!
The text was updated successfully, but these errors were encountered: