fix: panic when no record found

free5gc · Oct 31, 2024 · f4bfcea · f4bfcea
1 parent 0891e79
commit f4bfcea
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/internal/logger/logger.go b/internal/logger/logger.go
@@ -17,6 +17,7 @@ var (
 	CtxLog              *logrus.Entry
 	SBILog              *logrus.Entry
 	ConsumerLog         *logrus.Entry
+	ProcLog             *logrus.Entry
 	GinLog              *logrus.Entry
 	ChargingdataPostLog *logrus.Entry
 	NotifyEventLog      *logrus.Entry
@@ -43,6 +44,7 @@ func init() {
 	CtxLog = NfLog.WithField(logger_util.FieldCategory, "CTX")
 	SBILog = NfLog.WithField(logger_util.FieldCategory, "SBI")
 	ConsumerLog = NfLog.WithField(logger_util.FieldCategory, "Consumer")
+	ProcLog = NfLog.WithField(logger_util.FieldCategory, "Proc")
 	GinLog = NfLog.WithField(logger_util.FieldCategory, "GIN")
 	ChargingdataPostLog = NfLog.WithField(logger_util.FieldCategory, "ChargingPost")
 	NotifyEventLog = NfLog.WithField(logger_util.FieldCategory, "NotifyEvent")

diff --git a/internal/sbi/processor/cdr.go b/internal/sbi/processor/cdr.go
@@ -1,6 +1,7 @@
 package processor
 
 import (
+	"fmt"
 	"strings"
 	"time"
 
@@ -202,6 +203,10 @@ func (p *Processor) OpenCDR(
 func (p *Processor) UpdateCDR(
 	record *cdrType.CHFRecord, chargingData models.ChfConvergedChargingChargingDataRequest,
 ) error {
+	if record == nil {
+		return fmt.Errorf("CHFRecord is nil")
+	}
+
 	// map SBI IE to CDR field
 	chfCdr := record.ChargingFunctionRecord
 

diff --git a/internal/sbi/processor/converged_charging.go b/internal/sbi/processor/converged_charging.go
@@ -310,6 +310,7 @@ func (p *Processor) ChargingDataRelease(
 	if err != nil {
 		problemDetails := &models.ProblemDetails{
 			Status: http.StatusBadRequest,
+			Cause:  err.Error(),
 		}
 		return problemDetails
 	}