Skip to content

Commit 22e4b7d

Browse files
committed
Fix error with updating owl information during refresh
1 parent 130b5ac commit 22e4b7d

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

Diff for: blinkpy/helpers/constants.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
MAJOR_VERSION = 0
66
MINOR_VERSION = 16
7-
PATCH_VERSION = "0-rc7"
7+
PATCH_VERSION = "0-rc8"
88

99
__version__ = f"{MAJOR_VERSION}.{MINOR_VERSION}.{PATCH_VERSION}"
1010

Diff for: blinkpy/sync_module.py

+4-2
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def get_camera_info(self, camera_id, **kwargs):
171171
return response["camera"][0]
172172
except (TypeError, KeyError):
173173
_LOGGER.error("Could not extract camera info: %s", response, exc_info=True)
174-
return []
174+
return {}
175175

176176
def get_network_info(self):
177177
"""Retrieve network status."""
@@ -191,7 +191,9 @@ def refresh(self, force_cache=False):
191191
self.check_new_videos()
192192
for camera_name in self.cameras.keys():
193193
camera_id = self.cameras[camera_name].camera_id
194-
camera_info = self.get_camera_info(camera_id)
194+
camera_info = self.get_camera_info(
195+
camera_id, owl_info=self.get_owl_info(camera_name)
196+
)
195197
self.cameras[camera_name].update(camera_info, force_cache=force_cache)
196198
self.available = True
197199

Diff for: tests/test_sync_module.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,11 @@ def test_get_camera_info(self, mock_resp):
8080
def test_get_camera_info_fail(self, mock_resp):
8181
"""Test handling of failed get camera info function."""
8282
mock_resp.return_value = None
83-
self.assertEqual(self.blink.sync["test"].get_camera_info("1"), [])
83+
self.assertEqual(self.blink.sync["test"].get_camera_info("1"), {})
8484
mock_resp.return_value = {}
85-
self.assertEqual(self.blink.sync["test"].get_camera_info("1"), [])
85+
self.assertEqual(self.blink.sync["test"].get_camera_info("1"), {})
8686
mock_resp.return_value = {"camera": None}
87-
self.assertEqual(self.blink.sync["test"].get_camera_info("1"), [])
87+
self.assertEqual(self.blink.sync["test"].get_camera_info("1"), {})
8888

8989
def test_get_network_info(self, mock_resp):
9090
"""Test network retrieval."""

0 commit comments

Comments
 (0)