Merge pull request #741 from martindurant/http_isdir

isdir to give false when http url does not exist

Author: martindurant

fsspec/implementations/http.py

@@ -472,7 +472,10 @@ async def _glob(self, path, **kwargs):
 
     async def _isdir(self, path):
         # override, since all URLs are (also) files
-        return bool(await self._ls(path))
+        try:
+            return bool(await self._ls(path))
+        except (FileNotFoundError, ValueError):
+            return False
 
 
 class HTTPFile(AbstractBufferedFile):

fsspec/implementations/tests/test_http.py

@@ -276,6 +276,7 @@ def test_isdir(server):
     h = fsspec.filesystem("http")
     assert h.isdir(server + "/index/")
     assert not h.isdir(server + "/index/realfile")
+    assert not h.isdir(server + "doesnotevenexist")
 
 
 def test_policy_arg(server):