http: support upper case methods for POST/PUT

Author: isidentical

fsspec/implementations/http.py

@@ -275,8 +275,14 @@ async def gen_chunks():
         kw = self.kwargs.copy()
         kw.update(kwargs)
         session = await self.set_session()
-        meth = getattr(session, method)
 
+        method = method.lower()
+        if method not in ("post", "put"):
+            raise ValueError(
+                f"method has to be either 'post' or 'put', not: {method!r}"
+            )
+
+        meth = getattr(session, method)
         async with meth(lpath, data=gen_chunks(), **kw) as resp:
             self._raise_not_found_for_status(resp, lpath)
 

fsspec/implementations/tests/test_http.py

@@ -4,6 +4,7 @@
 import sys
 import threading
 import time
+from collections import ChainMap
 from http.server import BaseHTTPRequestHandler, HTTPServer
 
 import pytest
@@ -25,12 +26,15 @@
 
 
 class HTTPTestHandler(BaseHTTPRequestHandler):
-    files = {
+    static_files = {
         "/index/realfile": data,
         "/index/otherfile": data,
         "/index": index,
         "/data/20020401": listing,
     }
+    dynamic_files = {}
+
+    files = ChainMap(dynamic_files, static_files)
 
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
@@ -81,6 +85,8 @@ def do_POST(self):
             self.files[file_path] = self.rfile.read(length)
         self._respond(200)
 
+    do_PUT = do_POST
+
     def read_chunks(self):
         length = -1
         while length != 0:
@@ -142,6 +148,15 @@ def server():
         yield s
 
 
+@pytest.fixture
+def reset_files():
+    yield
+
+    # Reset the newly added files after the
+    # test is completed.
+    HTTPTestHandler.dynamic_files.clear()
+
+
 def test_list(server):
     h = fsspec.filesystem("http")
     out = h.glob(server + "/index/*")
@@ -432,7 +447,8 @@ def test_info(server):
     assert info["ETag"] == "xxx"
 
 
-def test_put_file(server, tmp_path):
+@pytest.mark.parametrize("method", ["POST", "PUT"])
+def test_put_file(server, tmp_path, method, reset_files):
     src_file = tmp_path / "file_1"
     src_file.write_bytes(data)
 
@@ -442,7 +458,7 @@ def test_put_file(server, tmp_path):
     with pytest.raises(FileNotFoundError):
         fs.info(server + "/hey")
 
-    fs.put_file(src_file, server + "/hey")
+    fs.put_file(src_file, server + "/hey", method=method)
     assert fs.info(server + "/hey")["size"] == len(data)
 
     fs.get_file(server + "/hey", dwl_file)