From cdd5e074894146de6eced9b14c39e81e2afb7b46 Mon Sep 17 00:00:00 2001 From: Paul <53956863+hutch3232@users.noreply.github.com> Date: Sat, 25 Jan 2025 12:02:41 -0600 Subject: [PATCH] Update defaults in docstring (#934) * ci: let `aiobotocore` handle `botocore` install --- .github/workflows/ci.yml | 1 - s3fs/core.py | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3a3c91b2..0f15af07 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,7 +39,6 @@ jobs: run: | pip install git+https://github.com/fsspec/filesystem_spec pip install --upgrade "aiobotocore${{ matrix.aiobotocore-version }}" - pip install --upgrade "botocore" --no-deps pip install . --no-deps pip list diff --git a/s3fs/core.py b/s3fs/core.py index bfd10476..5496628c 100644 --- a/s3fs/core.py +++ b/s3fs/core.py @@ -213,7 +213,7 @@ class S3FileSystem(AsyncFileSystem): If RequesterPays buckets are supported. default_block_size: int (None) If given, the default block size value used for ``open()``, if no - specific value is given at all time. The built-in default is 5MB. + specific value is given at all time. The built-in default is 50MB. default_fill_cache : Bool (True) Whether to use cache filling with open by default. Refer to ``S3File.open``. @@ -241,9 +241,9 @@ class S3FileSystem(AsyncFileSystem): session : aiobotocore AioSession object to be used for all connections. This session will be used inplace of creating a new session inside S3FileSystem. For example: aiobotocore.session.AioSession(profile='test_user') - max_concurrency : int (1) + max_concurrency : int (10) The maximum number of concurrent transfers to use per file for multipart - upload (``put()``) operations. Defaults to 1 (sequential). When used in + upload (``put()``) operations. Defaults to 10. When used in conjunction with ``S3FileSystem.put(batch_size=...)`` the maximum number of simultaneous connections is ``max_concurrency * batch_size``. We may extend this parameter to affect ``pipe()``, ``cat()`` and ``get()``. Increasing this