Set decodeDatesAsIso as true by default

Author: Mert Kirbuga

source/session.ts

@@ -106,7 +106,7 @@ export class Session<
       apiEndpoint = "/api",
       additionalHeaders = {},
       strictApi = false,
-      decodeDatesAsIso = false,
+      decodeDatesAsIso = true,
       ensureSerializableResponse = false,
     }: SessionOptions = {},
   ) {
@@ -389,7 +389,7 @@ export class Session<
     data: any,
     identityMap: Data = {},
     {
-      decodeDatesAsIso = false,
+      decodeDatesAsIso = true,
       ensureSerializableResponse = false,
     }: {
       decodeDatesAsIso?: boolean;
@@ -411,8 +411,6 @@ export class Session<
       }
       if (data.__type__ === "datetime" && decodeDatesAsIso) {
         return this._decodeDateTimeAsIso(data);
-      } else if (data.__type__ === "datetime") {
-        return this._decodeDateTimeAsDayJs(data);
       }
       return this._decodePlainObject(data, identityMap, {
         decodeDatesAsIso,
@@ -446,27 +444,6 @@ export class Session<
     return new Date(dateValue).toISOString();
   }
 
-  /**
-   * Decode datetime *data* into dayjs objects.
-   *
-   * Translate objects with __type__ equal to 'datetime' into dayjs
-   * datetime objects. If time zone support is enabled on the server the date
-   * will be assumed to be UTC and the dayjs will be in utc.
-   * @private
-   */
-  private _decodeDateTimeAsDayJs(data: any) {
-    if (
-      this.serverInformation &&
-      this.serverInformation.is_timezone_support_enabled
-    ) {
-      // Return date as dayjs object with UTC set to true.
-      return dayjs.utc(data.value);
-    }
-
-    // Return date as local dayjs object.
-    return dayjs(data.value);
-  }
-
   /**
    * Return new object where all values have been decoded.
    * @private
@@ -499,7 +476,7 @@ export class Session<
     collection: any[],
     identityMap: Data,
     {
-      decodeDatesAsIso = false,
+      decodeDatesAsIso = true,
       ensureSerializableResponse = false,
     }: {
       decodeDatesAsIso?: boolean;

test/session.test.ts

@@ -131,16 +131,6 @@ describe("Session", () => {
     return expect((await headers).get("ftrack-strict-api")).toEqual("true");
   });
 
-  it("Should allow querying with datetimes decoded as dayjs objects (default)", async () => {
-    const result = await session.query(
-      "select name, created_at from Task limit 1",
-    );
-    expect(result.data[0].created_at).toBeInstanceOf(dayjs);
-    expect(result.data[0].created_at.toISOString()).toEqual(
-      "2022-10-10T10:12:09.000Z",
-    );
-  });
-
   it("Should allow querying with datetimes decoded as ISO objects", async () => {
     const result = await session.query(
       "select name, created_at from Task limit 1",
@@ -163,30 +153,6 @@ describe("Session", () => {
     );
     expect(result.data[0].created_at).toEqual("2022-10-10T10:12:09.000Z");
   });
-  it("Should allow overriding session decodeDatesAsIso when querying", async () => {
-    const decodeDatesAsIsoSession = new Session(
-      credentials.serverUrl,
-      credentials.apiUser,
-      credentials.apiKey,
-      {
-        decodeDatesAsIso: true,
-      },
-    );
-    await decodeDatesAsIsoSession.initializing;
-    const result = await decodeDatesAsIsoSession.query(
-      "select name, created_at from Task limit 1",
-      { decodeDatesAsIso: false },
-    );
-    expect(result.data[0].created_at).toBeInstanceOf(dayjs);
-    expect(result.data[0].created_at.toISOString()).toEqual(
-      "2022-10-10T10:12:09.000Z",
-    );
-    const result2 = await session.query(
-      "select name, created_at from Task limit 1",
-      { decodeDatesAsIso: true },
-    );
-    expect(result2.data[0].created_at).toEqual("2022-10-10T10:12:09.000Z");
-  });
 
   it("Should allow querying with datetimes decoded as ISO objects with timezone support disabled", async () => {
     server.use(
@@ -837,20 +803,6 @@ describe("Encoding entities", () => {
       expect(data[2].status.state.short).toEqual("DONE");
     });
 
-    it("Should support decoding datetime as dayjs (default)", () => {
-      const now = dayjs();
-
-      //@ts-ignore - Otherwise internal method used for testing purposes
-      const output = session.decode({
-        foo: {
-          __type__: "datetime",
-          value: now.toISOString(),
-        },
-      });
-      expect(output.foo).toBeInstanceOf(dayjs);
-      expect(output.foo.toISOString()).toEqual(now.toISOString());
-    });
-
     it("Should support decoding datetime as ISO string", () => {
       const now = new Date();