Skip to content

Commit ea5e10c

Browse files
authored
Merge pull request #119 from chaitanya0bhagvan/master
Parity of response format between ios and android
2 parents 635f882 + e34988b commit ea5e10c

File tree

5 files changed

+17
-10
lines changed

5 files changed

+17
-10
lines changed

android/.idea/gradle.xml

+1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

android/src/main/java/io/fullstack/firestack/FirestackAuth.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,6 @@ public void onComplete(@NonNull Task<GetTokenResult> task) {
432432
WritableMap userMap = getUserMap();
433433
if (FirestackAuthModule.this.user != null) {
434434
final String token = task.getResult().getToken();
435-
436435
userMap.putString("token", token);
437436
userMap.putBoolean("anonymous", false);
438437
}
@@ -509,9 +508,10 @@ private WritableMap getUserMap() {
509508
userMap.putString("email", email);
510509
userMap.putString("uid", uid);
511510
userMap.putString("providerId", provider);
511+
userMap.putBoolean("emailVerified", user.isEmailVerified());
512512

513513
if (name != null) {
514-
userMap.putString("name", name);
514+
userMap.putString("displayName", name);
515515
}
516516

517517
if (photoUrl != null) {

android/src/main/java/io/fullstack/firestack/FirestackDatabase.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,12 @@ public String getName() {
304304
public void enablePersistence(
305305
final Boolean enable,
306306
final Callback callback) {
307-
FirebaseDatabase.getInstance()
307+
try {
308+
FirebaseDatabase.getInstance()
308309
.setPersistenceEnabled(enable);
310+
} catch (Throwable t) {
311+
Log.e(TAG, "FirebaseDatabase setPersistenceEnabled exception", t);
312+
}
309313

310314
WritableMap res = Arguments.createMap();
311315
res.putString("status", "success");

ios/Firestack/FirestackAuth.m

+8-6
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ @implementation FirestackAuth
2525
if (!user) {
2626
NSDictionary *evt = @{
2727
@"eventName": AUTH_ANONYMOUS_ERROR_EVENT,
28-
@"msg": [error localizedDescription]
28+
@"errorMessage": [error localizedDescription]
2929
};
3030

3131

@@ -41,7 +41,7 @@ @implementation FirestackAuth
4141
} @catch(NSException *ex) {
4242
NSDictionary *eventError = @{
4343
@"eventName": AUTH_ANONYMOUS_ERROR_EVENT,
44-
@"msg": ex.reason
44+
@"errorMessage": ex.reason
4545
};
4646

4747
[self sendJSEvent:AUTH_ERROR_EVENT
@@ -144,14 +144,15 @@ @implementation FirestackAuth
144144
sendJSEvent:AUTH_CHANGED_EVENT
145145
props: @{
146146
@"eventName": @"userTokenError",
147-
@"msg": [error localizedFailureReason]
147+
@"authenticated": @((BOOL)true),
148+
@"errorMessage": [error localizedFailureReason]
148149
}];
149150
} else {
150151
[self
151152
sendJSEvent:AUTH_CHANGED_EVENT
152153
props: @{
153154
@"eventName": @"user",
154-
@"authenticated": @(true),
155+
@"authenticated": @((BOOL)true),
155156
@"user": userProps
156157
}];
157158
}
@@ -164,7 +165,7 @@ @implementation FirestackAuth
164165
[self sendJSEvent:AUTH_CHANGED_EVENT
165166
props:@{
166167
@"eventName": @"no_user",
167-
@"authenticated": @(false),
168+
@"authenticated": @((BOOL)false),
168169
@"error": err
169170
}];
170171
}
@@ -185,7 +186,8 @@ @implementation FirestackAuth
185186
FIRUser *user = [FIRAuth auth].currentUser;
186187

187188
if (user != nil) {
188-
NSDictionary *userProps = [self userPropsFromFIRUser:user];
189+
NSMutableDictionary *userProps = [self userPropsFromFIRUser:user];
190+
[userProps setValue: @((BOOL)true) forKey: @"authenticated"];
189191
callback(@[[NSNull null], userProps]);
190192
} else {
191193
// No user is signed in.

lib/modules/database.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -514,4 +514,4 @@ export class Database extends Base {
514514
}
515515
}
516516

517-
export default Database
517+
export default Database

0 commit comments

Comments
 (0)