Skip to content

Commit ef4890a

Browse files
committed
Added Github auth and updated README
1 parent 17f41c7 commit ef4890a

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

Diff for: README.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@ For a detailed discussion of how Firestack works as well as how to contribute, c
1616
* Covers lots of awesome features of Firebase:
1717
* authentication
1818
* username and password
19-
* social auth (implemented, but need to add providers)
19+
* social auth (implemented in conjunction with [react-native-oauth](https://github.com/fullstackreact/react-native-oauth))
20+
* Facebook
21+
* Github
22+
* Google
23+
* Twitter
2024
* storage handling
2125
* upload files
2226
* download urls
@@ -25,6 +29,7 @@ For a detailed discussion of how Firestack works as well as how to contribute, c
2529
* presence out-of-the-box
2630
* analytics
2731
* Remote configuration
32+
* FCM (in-progress)
2833
* Redux support built-in (but not required)
2934
* Android and iOS support
3035
* Community supported and professionally backed

Diff for: ios/Firestack/FirestackAuth.m

+3
Original file line numberDiff line numberDiff line change
@@ -486,6 +486,9 @@ - (FIRAuthCredential *)getCredentialForProvider:(NSString *)provider
486486
} else if ([provider compare:@"google" options:NSCaseInsensitiveSearch] == NSOrderedSame) {
487487
credential = [FIRGoogleAuthProvider credentialWithIDToken:authToken
488488
accessToken:authTokenSecret];
489+
} else if ([provider compare:@"github" options:NSCaseInsensitiveSearch] == NSOrderedSame) {
490+
credential = [FIRGitHubAuthProvider credentialWithIDToken:authToken
491+
accessToken:authTokenSecret];
489492
} else {
490493
NSLog(@"Provider not yet handled: %@", provider);
491494
}

0 commit comments

Comments
 (0)