Update widget_test.dart for an upstream LayoutBuilder fix #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LayoutBuilder migration: LayoutBuilders no longer do double layout (currently the fix is behind a temporary flag). Related flutter/flutter PR: flutter/flutter#147856
LongCatIsLooong
changed the title
|
Hi, could you please comment out that line and make a comment pointing to this? Thanks! |
|
Done. For posterity, I think the flutter version specified in the github action has to be updated / unpinned at some point so the |
|
Totally agree! Btw, have you tried to update it (i.e. does CI directly work on 3.22)? I have not tried 3.22 yet, but if it works directly, then this PR may include that update. EDIT: Make a PR here: #114 |
|
Sorry I have not tried 3.22. The migration flag isn't part of the current stable release either (the pr that introduced it was merged today). |
Closed
|
Oh I see, no problem! |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LayoutBuilder migration: LayoutBuilders no longer do double layout (currently the fix is behind a temporary flag
LayoutBuilder.applyDoubleRebuildFix).Related flutter/flutter PR: flutter/flutter#147856
Unfortunately the presubmit checks are currently run against the stable branch of flutter which does not have the migration flag yet so I removed the
expectstatement altogether.flutter_portal/.github/workflows/build.yml
Lines 14 to 17 in 786cd79