Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep close button visible when editing attributes panel is open #67

Open
Raruto opened this issue Oct 10, 2023 · 2 comments
Open

Keep close button visible when editing attributes panel is open #67

Raruto opened this issue Oct 10, 2023 · 2 comments
Labels
ux Changes to a current behavior to improve user experience

Comments

@Raruto
Copy link
Collaborator

Raruto commented Oct 10, 2023

Motivation

As per [email protected],

top right close button "disappears" (changes its position) when you open the editing tools:

image

image

image

Suggested solution

In order to avoid confusing end user, it is best to keep both close buttons visible:

image

@Raruto Raruto added the ux Changes to a current behavior to improve user experience label Oct 10, 2023
@volterra79
Copy link
Member

volterra79 commented Oct 11, 2023

@Raruto Close (x) is hide by code because otherwise we need to intercept click on x (close button) and use the same flow of click on close button (no save)

@Raruto
Copy link
Collaborator Author

Raruto commented Oct 12, 2023

Close (x) is hide by code ... and use the same flow

@volterra79 please, include a few permalinks to the relevant portions of code (so in the future we will know where to start looking for)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux Changes to a current behavior to improve user experience
Projects
None yet
Development

No branches or pull requests

2 participants