Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pagination should not be required parameter in beaconReceivedRequestSummary #51

Closed
mbaudis opened this issue Nov 16, 2022 · 1 comment
Closed

pagination should not be required parameter in beaconReceivedRequestSummary #51

mbaudis opened this issue Nov 16, 2022 · 1 comment
Assignees
@jrambla
Labels
Dev scout enhancement New feature or request

Comments

@mbaudis
Copy link
Member

mbaudis commented Nov 16, 2022

Pagination should not be required parameter in beaconReceivedRequestSummary since it doesn't make sense in Boolean and count responses (and also not if all data is returned but here YMMV).

beacon-v2/framework/src/responses/sections/beaconReceivedRequestSummary.yaml

Line 50 in eb8958f

- pagination

@mbaudis mbaudis added the invalid This doesn't seem right label Nov 16, 2022
@mbaudis mbaudis added enhancement New feature or request and removed invalid This doesn't seem right labels Dec 12, 2022
@jrambla
Copy link
Contributor

jrambla commented Sep 12, 2024

This issue is also discussed in the issue #55

@jrambla jrambla closed this as completed Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrambla jrambla

Labels
Dev scout enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbaudis @jrambla