performance: add frontend variables only when there is a block that needs them #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prconcepcion
changed the title
🤖 Pull request artifacts
|
|
Size Change: +193 B (0%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
bfintal
requested changes
Dec 21, 2023
bfintal
reviewed
Jan 3, 2024
bfintal
requested changes
Jan 3, 2024
src/init.php
Outdated
| public function init_stackable_vars() { | ||
| $args = apply_filters( 'stackable_localize_frontend_script', array() ); | ||
| if ( array_key_exists( 'restUrl', $args ) ) { | ||
| echo '<script> stackable = {"restUrl": "' . $args["restUrl"] .'"} </script>'; |
There was a problem hiding this comment.
instead of writing the restUrl manually, please convert $args to JSON instead to print out the entire $args if it has contents
bfintal
reviewed
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3007