create temporary new icon list block #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
|
Size Change: +2.97 kB (0%) Total Size: 1.99 MB
ℹ️ View Unchanged
|
|
Fixed: allow nested icon lists Additional Issue:
|
|
Additional issue:
Screen.Recording.2024-01-03.at.12.27.59.PM.mov |
fixes navigation to adjacent li blocks
bfintal
requested changes
Jan 25, 2024
There was a problem hiding this comment.
Some change requests:
- Please add a default column gap of 16px (make sure this is only applicable for new icon lists)
- Also adjust the placeholder in the option
- If 2+ columns, the columns should align to the entire width (right now it's collapsed to the left)
- If the layout > content alignment is left/center/right, then do not apply the full width
- Icon list item borders > border width should default to 1px (it's currently thick)
- control should have placeholder of
1
- control should have placeholder of
- Icon list item borders > border color should default to
#00000066 - Add new option under Icon list item borders "Full Width Borders" (toggle), the borders should go fullwidth (I think this will just make the width
auto) - Add new Icon Vertical Alignment option for the icon, add option in Icons & Numbers. it should be a button group like top, center, bottom like the other options.
- Help description: "Visible if you have long text in your list"
- Add a new Icon Vertical Offset option under the Icon Vertical Alignment option. Values are from -50 to 50 (default at 0), this should add
margin-topto the icon
add default column gap, fix column & content alignment, fix default border values, add new settings: Full Width Borders, Icon Vertical Alignment, & Icon Vertical Offset
responsive border width, fix width when content vertical align is set
bfintal
requested changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2818
Remaining Issues: