Fix/accordion highlight #3182
Merged
Fix/accordion highlight #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Pull request artifacts
|
bfintal
requested changes
May 20, 2024
Comment on lines
33
to
35
| // Prevent text selection while animating | ||
| const content = el.querySelector( '.stk-block-accordion__content' ) | ||
| content.style.userSelect = 'none' |
There was a problem hiding this comment.
It seems that doing this on the content would still make the text highlight. I would recommend doing this on the element itself to prevent this:
Suggested change
| // Prevent text selection while animating | |
| const content = el.querySelector( '.stk-block-accordion__content' ) | |
| content.style.userSelect = 'none' | |
| // Prevent text selection while animating | |
| el.style.userSelect = 'none' |
Comment on lines
61
to
71
| if ( window.getSelection ) { | ||
| // eslint-disable-next-line @wordpress/no-global-get-selection | ||
| const selection = window.getSelection() | ||
| if ( selection.removeAllRanges ) { | ||
| selection.removeAllRanges() | ||
| } | ||
| } else if ( document.selection ) { | ||
| // For older IE browsers | ||
| document.selection.empty() | ||
| } | ||
| content.style.userSelect = 'auto' |
There was a problem hiding this comment.
I see that you are clearing the selection because the userSelect above was not taking full effect and you can still highlight text when opening an accordion. Applying the style directly on the element fixes things, and now you do not need all of the selection removal code.
Also, to me, if the fix only partially works and you needed to add some selection removal code to compensate is an indicator that there should be a cleaner solution 👍
Suggested change
| if ( window.getSelection ) { | |
| // eslint-disable-next-line @wordpress/no-global-get-selection | |
| const selection = window.getSelection() | |
| if ( selection.removeAllRanges ) { | |
| selection.removeAllRanges() | |
| } | |
| } else if ( document.selection ) { | |
| // For older IE browsers | |
| document.selection.empty() | |
| } | |
| content.style.userSelect = 'auto' | |
| el.style.userSelect = 'auto' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3096